[Sound-open-firmware] [PATCH] ssp: fix inverted_frame handling for BYT and APL/CNL

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Fri Mar 9 16:24:21 CET 2018


inverted_frame variable should only be set in the _IF
cases

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
---
This should apply on top of Keyon's APL/CNL fixes

 src/drivers/apl-ssp.c | 2 +-
 src/drivers/ssp.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/drivers/apl-ssp.c b/src/drivers/apl-ssp.c
index 42ffd03..1ee107c 100644
--- a/src/drivers/apl-ssp.c
+++ b/src/drivers/apl-ssp.c
@@ -196,6 +196,7 @@ static inline int ssp_set_config(struct dai *dai,
 	case SOF_DAI_FMT_NB_NF:
 		break;
 	case SOF_DAI_FMT_NB_IF:
+		inverted_frame = true; /* handled later with format */
 		break;
 	case SOF_DAI_FMT_IB_IF:
 		sspsp |= SSPSP_SCMODE(2);
@@ -203,7 +204,6 @@ static inline int ssp_set_config(struct dai *dai,
 		break;
 	case SOF_DAI_FMT_IB_NF:
 		sspsp |= SSPSP_SCMODE(2);
-		inverted_frame = true; /* handled later with format */
 		break;
 	default:
 		trace_ssp_error("ec3");
diff --git a/src/drivers/ssp.c b/src/drivers/ssp.c
index 4b195ec..827a4d8 100644
--- a/src/drivers/ssp.c
+++ b/src/drivers/ssp.c
@@ -223,6 +223,7 @@ static inline int ssp_set_config(struct dai *dai,
 	case SOF_DAI_FMT_NB_NF:
 		break;
 	case SOF_DAI_FMT_NB_IF:
+		inverted_frame = true; /* handled later with format */
 		break;
 	case SOF_DAI_FMT_IB_IF:
 		sspsp |= SSPSP_SCMODE(2);
@@ -230,7 +231,6 @@ static inline int ssp_set_config(struct dai *dai,
 		break;
 	case SOF_DAI_FMT_IB_NF:
 		sspsp |= SSPSP_SCMODE(2);
-		inverted_frame = true; /* handled later with format */
 		break;
 	default:
 		trace_ssp_error("ec3");
-- 
2.14.1



More information about the Sound-open-firmware mailing list