[Sound-open-firmware] [PATCH] pipeline: fix error handling

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Fri Mar 9 00:06:54 CET 2018


missing assignment of 'ret' variable, fix
Detected with sonarcloud.

Fixes: 4252c49d537 ('pipeline: Add XRUN state and handler within pipeline')
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
---
 src/audio/pipeline.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/audio/pipeline.c b/src/audio/pipeline.c
index 728b64d..c7f8aed 100644
--- a/src/audio/pipeline.c
+++ b/src/audio/pipeline.c
@@ -1063,14 +1063,14 @@ static int pipeline_xrun_recover(struct pipeline *p)
 	p->xrun_bytes = 0;
 
 	/* prepare the pipeline */
-	pipeline_prepare(p, p->source_comp);
+	ret = pipeline_prepare(p, p->source_comp);
 	if (ret < 0) {
 		trace_pipe_error("px1");
 		return ret;
 	}
 
 	/* restart pipeline comps */
-	pipeline_cmd(p, p->source_comp, COMP_CMD_START, NULL);
+	ret = pipeline_cmd(p, p->source_comp, COMP_CMD_START, NULL);
 	if (ret < 0) {
 		trace_pipe_error("px2");
 		return ret;
-- 
2.14.1



More information about the Sound-open-firmware mailing list