[Sound-open-firmware] [PATCH 3/3] topology: replace SSP_SAMPLE_BITS() users with SSP_CONFIG_DATA()

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Thu Jun 21 15:24:17 CEST 2018


The existing topologies don't need the MCLK ID so far, but...

> diff --git a/topology/test/test-all.m4 b/topology/test/test-all.m4
> index 2a4dae4..00318b0 100644
> --- a/topology/test/test-all.m4
> +++ b/topology/test/test-all.m4
> @@ -90,5 +90,5 @@ DAI_CONFIG(TEST_DAI_TYPE, TEST_DAI_PORT, 0, TEST_DAI_LINK_NAME,
>   		      DAI_CLOCK(bclk, TEST_SSP_BCLK, codec_slave),
>   		      DAI_CLOCK(fsync, 48000, codec_slave),
>   		      DAI_TDM(2, TEST_SSP_PHY_BITS, 3, 3),
> -		      SSP_SAMPLE_BITS(TEST_DAI_TYPE, TEST_DAI_PORT,
> +		      SSP_CONFIG_DATA(TEST_DAI_TYPE, TEST_DAI_PORT,
>   				      TEST_SSP_DATA_BITS)))
> diff --git a/topology/test/test-capture.m4 b/topology/test/test-capture.m4
> index 7e5ca86..9d85009 100644
> --- a/topology/test/test-capture.m4
> +++ b/topology/test/test-capture.m4
> @@ -74,7 +74,7 @@ DAI_CONFIG(TEST_DAI_TYPE, TEST_DAI_PORT, 0, TEST_DAI_LINK_NAME,
>   			     DAI_CLOCK(bclk, TEST_SSP_BCLK, codec_slave),
>   			     DAI_CLOCK(fsync, 48000, codec_slave),
>   			     DAI_TDM(2, TEST_SSP_PHY_BITS, 3, 3),
> -			     SSP_SAMPLE_BITS(TEST_DAI_TYPE, TEST_DAI_PORT,
> +			     SSP_CONFIG_DATA(TEST_DAI_TYPE, TEST_DAI_PORT,
>   					     TEST_SSP_DATA_BITS)),
>   		  TEST_DAI_TYPE, `DMIC',
>   		  DMIC_CONFIG(TEST_DMIC_DRIVER_VERSION,TEST_DMIC_CLK_MIN,
> diff --git a/topology/test/test-playback.m4 b/topology/test/test-playback.m4
> index ade8a8e..d607d3a 100644
> --- a/topology/test/test-playback.m4
> +++ b/topology/test/test-playback.m4
> @@ -73,5 +73,5 @@ DAI_CONFIG(TEST_DAI_TYPE, TEST_DAI_PORT, 0, TEST_DAI_LINK_NAME,
>   		      DAI_CLOCK(bclk, TEST_SSP_BCLK, codec_slave),
>   		      DAI_CLOCK(fsync, 48000, codec_slave),
>   		      DAI_TDM(2, TEST_SSP_PHY_BITS, 3, 3),
> -		      SSP_SAMPLE_BITS(TEST_DAI_TYPE, TEST_DAI_PORT,
> +		      SSP_CONFIG_DATA(TEST_DAI_TYPE, TEST_DAI_PORT,
>   				      TEST_SSP_DATA_BITS)))
> diff --git a/topology/test/test-tone-playback.m4 b/topology/test/test-tone-playback.m4
> index 971a41c..04f1566 100644
> --- a/topology/test/test-tone-playback.m4
> +++ b/topology/test/test-tone-playback.m4
> @@ -62,5 +62,5 @@ DAI_CONFIG(TEST_DAI_TYPE, TEST_DAI_PORT, 0, TEST_DAI_LINK_NAME,
>   		      DAI_CLOCK(bclk, TEST_SSP_BCLK, codec_slave),
>   		      DAI_CLOCK(fsync, 48000, codec_slave),
>   		      DAI_TDM(2, TEST_SSP_PHY_BITS, 3, 3),
> -		      SSP_SAMPLE_BITS(TEST_DAI_TYPE, TEST_DAI_PORT,
> +		      SSP_CONFIG_DATA(TEST_DAI_TYPE, TEST_DAI_PORT,
>   				      TEST_SSP_DATA_BITS)))
> 

... could we add this parameter to the test topologies for APL+? this 
would help us test the one platform where it's needed and remove the 
firmware change currently required.
Thanks!



More information about the Sound-open-firmware mailing list