[Sound-open-firmware] [PATCH v3 2/2] platform: apl platform should support 8 channels

[Liam Girdwood]

On Thu, 2018-06-21 at 09:10 +0800, zhigangw wrote:
> 
> On 2018年06月20日 18:25, Liam Girdwood wrote:
> > On Wed, 2018-06-20 at 11:04 +0800, Wu Zhigang wrote:
> > > apollolake platform should support 8-channel.
> > > 
> > > Signed-off-by: Wu Zhigang <zhigang.wu at linux.intel.com>
> > > 
> > > ---
> > > test with:
> > > apl-gpmrb with tdf8532 codec
> > > 
> > > linux topic/sof-dev: 0d51a5ed28c5
> > > sof master:          48d2a1c551d7
> > > soft master:         2cc3ad2a9287
> > > 
> > > pass the regression test:
> > > Minnowboard Turbo
> > > UP^2
> > > CNL-RVP
> > > ---
> > >   src/platform/apollolake/include/platform/platform.h | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/src/platform/apollolake/include/platform/platform.h
> > > b/src/platform/apollolake/include/platform/platform.h
> > > index 1cce0c7..04badb6 100644
> > > --- a/src/platform/apollolake/include/platform/platform.h
> > > +++ b/src/platform/apollolake/include/platform/platform.h
> > > @@ -66,7 +66,7 @@ struct sof;
> > >   #define PLATFORM_HOST_DMA_MASK	0x00000000
> > >   
> > >   /* Platform stream capabilities */
> > > -#define PLATFORM_MAX_CHANNELS	4
> > > +#define PLATFORM_MAX_CHANNELS	8
> > >   #define PLATFORM_MAX_STREAMS	16
> > >   
> > 
> > Applied patch 1/2.
> > 
> > max channels should be 16 for BYT, HSW, APL and CNL given that the SSP port
> > can
> > playback 16 channels.
> > 
> > Liam
> 
> Are you sure of this?
> I checked the SSP's register for CNL: SSTSA and SSRSA. It only supports 
> 8-channel.


You and Pierre are right (it's 8), I was looking at a recent driver patch that
had the wrong value.

Liam