[Sound-open-firmware] [PATCH 3/5] DMIC: add empty get_loopback_mode function

[Ranjani Sridharan]

On Tue, 2018-06-19 at 12:03 +0100, Liam Girdwood wrote:
> On Tue, 2018-06-19 at 17:22 +0800, Xiuli Pan wrote:
> >  
> > +static inline int dmic_get_loopback_mode(struct dai *dai)
> > +{
> > +       return -EINVAL;
> > +}
> > +
> >  const struct dai_ops dmic_ops = {
> >         .trigger = dmic_trigger,
> >         .set_config = dmic_set_config,
> > @@ -1360,6 +1365,7 @@ const struct dai_ops dmic_ops = {
> >         .pm_context_restore = dmic_context_restore,
> >         .probe = dmic_probe,
> >         .set_loopback_mode = dmic_set_loopback_mode,
> > +       .get_loopback_mode = dmic_get_loopback_mode,

Do we even need to define the get/set for loopback mode for DMIC if it
is not supported?
> 
> 
> Lest get rid of set/get loopback mode and use the standard component
> cmd APIs,
> I'm sure I've said this in an earlier version of this patch.
> 
> Liam
> 
> >  };
> >  
> 
> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware