[Sound-open-firmware] [PATCH 1/5] dai: add lbm status for dai ssp

Liam Girdwood liam.r.girdwood at linux.intel.com
Tue Jun 19 13:01:39 CEST 2018


On Tue, 2018-06-19 at 17:22 +0800, Xiuli Pan wrote:
> diff --git a/src/include/sof/ssp.h b/src/include/sof/ssp.h
> index fdcfcac..92db71f 100644
> --- a/src/include/sof/ssp.h
> +++ b/src/include/sof/ssp.h
> @@ -231,6 +231,7 @@ struct ssp_pdata {
>         uint32_t psp;
>         spinlock_t lock;
>         uint32_t state[2];              /* SSP_STATE_ for each direction */
> +       uint32_t lbm;


This is probably better as a bitfield flag and probably made generic in
sof_ipc_dai_config. That way we can reuse this whole infrastructure for other
non SSP DAIs.

I would also probably rename to loopback_control;

Liam

>         completion_t drain_complete;
>         struct sof_ipc_dai_config config;
>         struct sof_ipc_dai_ssp_params params;


More information about the Sound-open-firmware mailing list