[Sound-open-firmware] [PATCH 1/2] dai: add lbm status for dai

[Pan, Xiuli]

On 6/14/2018 02:53, Liam Girdwood wrote:
> On Wed, 2018-06-13 at 17:24 +0800, Xiuli Pan wrote:
>> From: Pan Xiuli <xiuli.pan at linux.intel.com>
>>
>> Add a status to track dai lbm.
>>
>> Signed-off-by: Pan Xiuli <xiuli.pan at linux.intel.com>
>>
>> ---
>> Work with patch set:
>> SOF-Kernel:
>>    ASoC: SOF: Add debug_mode flag in sof dev
>>    ASoC: SOF: debug: add debugmode debugfs for sof_dev debug_mode
>>    ASoC: SOF: uapi: topology: Add SOF_TKN_DAI_LBM for ssp loopback mode
>>    ASoC: SOF: uapi: ipc: Add lbm in sof_ipc_dai_config
>>    ASoC: SOF: topology: Add topology handler for dai config loopback mode
>>    ASoC: SOF: add headers for lbm control callback functions
>>    ASoC: SOF: add lbm kcontrol callback functions
>>    ASoC: SOF: topology: add SSP lbm kcontrol switch create function
>> SOF:
>>    dai: add lbm status for dai
>>    ipc: dai: add loopback mode handler for dai
>> SOF-Tools:
>>    topology: Add SOF_TKN_DAI_LBM for ssp loopback mode
>>    topology: m4: Add option for loopback mode in DAI config
>>    topology: test: Add loopback topology
>>
>> test & santity test with:
>> Mininow max rt5651 and UP2 Hifiberry PRO and CNL nocodec
>> SOF master: 792bd414ee5629f72b1e24619510d6936eac28ce
>> SOF-Tool master: bd7dc88231f31d385340310cef467f211a739eeb
>> https://github.com/plbossart/sound/tree/topic/sof-v4.14:
>> 1e0f50565669815dd7daa19021b3b04a90487431
>>
>> ---
>>   src/include/sof/dai.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/include/sof/dai.h b/src/include/sof/dai.h
>> index e3bce1d..8f4c69e 100644
>> --- a/src/include/sof/dai.h
>> +++ b/src/include/sof/dai.h
>> @@ -98,6 +98,7 @@ struct dai_plat_data {
>>   struct dai {
>>   	uint32_t type;
>>   	uint32_t index;
>> +	uint32_t lbm;
> This is platform data and this should not store runtime status. What is lbm and
> what is it use for, please rename it with more meaningful name.
Then the status should go to private data?
Will rename it and send a V2.

Thanks
Xiuli
>
>>   	struct dai_plat_data plat_data;
>>   	const struct dai_ops *ops;
>>   	void *private;
> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware