[Sound-open-firmware] [PATCH] arch: xtensa: set SRAM window error codes during bootloader

[Lauda, Tomasz]

On 12.06.2018 06:28, Keyon Jie wrote:

>
>
> On 2018年06月12日 11:51, Ranjani Sridharan wrote:
>> On Mon, 2018-06-11 at 13:10 +0800, Pan, Xiuli wrote:
>>>
>>> On 6/9/2018 03:06, Liam Girdwood wrote:
>>>> On Fri, 2018-06-08 at 19:42 +0100, Liam Girdwood wrote:
>>>>> From: Kamil Kulesza <kamil.kulesza at linux.intel.com>
>>>>>
>>>>> Set status (0x05) and error (0x00) code in Memory Window 0 when
>>>>> the bootloader
>>>>> starts.
>>>>> boot_entry.S - set status (0x05) and error (0x00) code before
>>>>> wnd0 reprogram
>>>>> platform/memory.h - increase bootloader size
>>>>>
>>>>> Signed-off-by: Kamil Kulesza <kamil.kulesza at linux.intel.com>
>>>>> ---
>>>>>    src/arch/xtensa/boot_entry.S                  | 22
>>>>> +++++++++++++++++++
>>>>>    .../apollolake/include/platform/memory.h      |  2 +-
>>>>>    .../cannonlake/include/platform/memory.h      |  2 +-
>>>>>    3 files changed, 24 insertions(+), 2 deletions(-)
>>>>>
>>>>>
>>>
>>> This patch seems to be a workaround for the firmware boot up. The
>>> status
>>> (0x05) should be set by the rom.
>>> With the rmbox and dump data from status registers. It seems all
>>> memory
>>> window is fulled with rodata of the firmware. I think there is some
>>> potential bugs for memory window.
>>> If this is not a bug maybe we need to add memset for memory windows.
>>
>> Xiuli/Liam/Tomasz,
>>
>> There is a regression due to the set of the bootloader patches on my up
>> squared board. The audio is distorted now.
>>
>> I reverted these patches and I could hear clean audio.
>
> + Keqiao who may reported similar issue on UP^2.
> Hi Keqiao, can you check what Ranjani founded?
>
> Thanks,
> ~Keyon

Glitches are probably due to the problem with Host DMA not exiting L1 
state on time.
Bootloader patch enabled L1 cache on APL, so that's why you are seeing 
the problem now.
It will be fixed after my pm_runtime patch will go through.

>
>>
>> Thanks,
>> Ranjani
>>
>>>
>>> Thanks
>>> Xiuli
>>>
>>>> Applied.
>>>>
>>>> Thanks
>>>>
>>>> Liam
>>>> _______________________________________________
>>>> Sound-open-firmware mailing list
>>>> Sound-open-firmware at alsa-project.org
>>>> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmwar
>>>> e
>>>
>>> _______________________________________________
>>> Sound-open-firmware mailing list
>>> Sound-open-firmware at alsa-project.org
>>> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
>> _______________________________________________
>> Sound-open-firmware mailing list
>> Sound-open-firmware at alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
>>
> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware