[Sound-open-firmware] [PATCH] arch: xtensa: set SRAM window error codes during bootloader

[Lauda, Tomasz]

FW sets MW0 to different address than ROM.
We are setting status 0x05 from bootloader, so it's the correct assumption, that ROM jumped out to FW correctly.

Tomek


-----Original Message-----
From: sound-open-firmware-bounces at alsa-project.org [mailto:sound-open-firmware-bounces at alsa-project.org] On Behalf Of Pan, Xiuli
Sent: Monday, June 11, 2018 7:11 AM
To: Liam Girdwood <liam.r.girdwood at linux.intel.com>; sound-open-firmware at alsa-project.org
Cc: Kamil Kulesza <kamil.kulesza at linux.intel.com>
Subject: Re: [Sound-open-firmware] [PATCH] arch: xtensa: set SRAM window error codes during bootloader



On 6/9/2018 03:06, Liam Girdwood wrote:
> On Fri, 2018-06-08 at 19:42 +0100, Liam Girdwood wrote:
>> From: Kamil Kulesza <kamil.kulesza at linux.intel.com>
>>
>> Set status (0x05) and error (0x00) code in Memory Window 0 when the 
>> bootloader starts.
>> boot_entry.S - set status (0x05) and error (0x00) code before wnd0 
>> reprogram platform/memory.h - increase bootloader size
>>
>> Signed-off-by: Kamil Kulesza <kamil.kulesza at linux.intel.com>
>> ---
>>   src/arch/xtensa/boot_entry.S                  | 22 +++++++++++++++++++
>>   .../apollolake/include/platform/memory.h      |  2 +-
>>   .../cannonlake/include/platform/memory.h      |  2 +-
>>   3 files changed, 24 insertions(+), 2 deletions(-)
>>
>>
This patch seems to be a workaround for the firmware boot up. The status
(0x05) should be set by the rom.
With the rmbox and dump data from status registers. It seems all memory window is fulled with rodata of the firmware. I think there is some potential bugs for memory window.
If this is not a bug maybe we need to add memset for memory windows.

Thanks
Xiuli

> Applied.
>
> Thanks
>
> Liam
> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware

_______________________________________________
Sound-open-firmware mailing list
Sound-open-firmware at alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.