[Sound-open-firmware] [PATCH 1/3] configure: Change install prefix for bin and keys

[Pan, Xiuli]

On 6/9/2018 03:05, Liam Girdwood wrote:
> On Fri, 2018-06-08 at 18:32 +0800, Xiuli Pan wrote:
>> From: Pan Xiuli <xiuli.pan at linux.intel.com>
>>
>> Install prefix will not influce PEM install path. Add the check to let
>> PEM can install with the prefix.
>>
>> Signed-off-by: Pan Xiuli <xiuli.pan at linux.intel.com>
>> ---
>>   configure.ac | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 0f34acc..a948906 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -358,7 +358,11 @@ if test "$have_rimage" = "yes"; then
>>   	fi
>>   fi
>>   
>> +if test "x$prefix" == "xNONE"; then
>>   PEM_KEY_PREFIX="/usr/local/share/rimage"
>> +else
>> +PEM_KEY_PREFIX=$prefix"/share/rimage"
>> +fi
>>   AC_DEFINE_UNQUOTED([PEM_KEY_PREFIX], ["$PEM_KEY_PREFIX"], ["Path for PEM
>> keys"])
>>   AC_SUBST(PEM_KEY_PREFIX)
>>   
>> @@ -448,6 +452,7 @@ echo "
>>   Target Architecture:           ${ARCH}
>>   Target Platform:               ${PLATFORM}
>>   Target Core:                   ${XTENSA_CORE}
>> +Install Prefix:                ${prefix}
>>   PEM:                           ${PEM_KEY_PREFIX}
>>   
>>   Compiler:                      ${CC}
>
> Both building with -l and without fails. :-
>
> With -l
I found that I have some mismatch for the variable name in on of the loop.
> make[2]: Leaving directory '/home/lrg/source/reef/sof.git'
> make[1]: Leaving directory '/home/lrg/source/reef/sof.git'
> ./scripts/xtensa-build-all.sh: line 59: [: ==: unary operator expected
> ./scripts/xtensa-build-all.sh: line 64: [: ==: unary operator expected
> ./scripts/xtensa-build-all.sh: line 69: [: ==: unary operator expected
> ./scripts/xtensa-build-all.sh: line 74: [: ==: unary operator expected
> ./scripts/xtensa-build-all.sh: line 79: [: ==: unary operator expected
> ./scripts/xtensa-build-all.sh: line 84: [: ==: unary operator expected
> checking for a BSD-compatible install... /usr/bin/install -c
> checking whether build environment is sane... yes
> checking for a thread-safe mkdir -p... /bin/mkdir -p
> checking for gawk... gawk
> checking whether make sets $(MAKE)... yes
> checking whether make supports nested variables... yes
> checking whether UID '1000' is supported by ustar format... yes
> checking whether GID '1000' is supported by ustar format... yes
> checking how to create a ustar tar archive... gnutar
> checking whether to enable maintainer-specific portions of Makefiles... yes
> checking build system type... x86_64-pc-linux-gnu
> checking host system type... x86_64-pc-linux-gnu
> configure: error: Host platform not specified
>
> without :-
I realized there is a bug for without no args yesterday when I think 
about this patch.
It will do nothing for this.

Will send a v2 version.

Thanks
Xiuli
>
> make[3]: Leaving directory '/home/lrg/source/reef/sof.git/rimage/keys'
> make[2]: Leaving directory '/home/lrg/source/reef/sof.git/rimage/keys'
> make[2]: Entering directory '/home/lrg/source/reef/sof.git/rimage'
> make[3]: Entering directory '/home/lrg/source/reef/sof.git/rimage'
>   /bin/mkdir -p '/usr/local/bin'
>    /bin/bash ../libtool   --mode=install /usr/bin/install -c rimage '/usr/local/bin'
> libtool: install: /usr/bin/install -c rimage /usr/local/bin/rimage
> make[3]: Nothing to be done for 'install-data-am'.
> make[3]: Leaving directory '/home/lrg/source/reef/sof.git/rimage'
> make[2]: Leaving directory '/home/lrg/source/reef/sof.git/rimage'
> make[1]: Leaving directory '/home/lrg/source/reef/sof.git/rimage'
> make[1]: Entering directory '/home/lrg/source/reef/sof.git'
> make[2]: Entering directory '/home/lrg/source/reef/sof.git'
> make[2]: Nothing to be done for 'install-exec-am'.
> make[2]: Nothing to be done for 'install-data-am'.
> make[2]: Leaving directory '/home/lrg/source/reef/sof.git'
> make[1]: Leaving directory '/home/lrg/source/reef/sof.git'
> ls: cannot access 'src/arch/xtensa/*.ri': No such file or directory
>
> Please test this stuff.
>
> Thanks
>
> Liam