[Sound-open-firmware] [PATCH 2/2] topology: 8-channel should be supported

[Keyon Jie]

On 2018年06月08日 13:45, zhigangw wrote:
> 
> 
> On 2018年06月08日 13:40, Ranjani Sridharan wrote:
>> On Fri, 2018-06-08 at 13:13 +0800, zhigangw wrote:
>>> On 2018年06月08日 13:05, Ranjani Sridharan wrote:
>>>> On Fri, 2018-06-08 at 13:01 +0800, zhigangw wrote:
>>>>> On 2018年06月08日 13:00, Ranjani Sridharan wrote:
>>>>>> On Fri, 2018-06-08 at 12:38 +0800, Wu Zhigang wrote:
>>>>>>> 8 channels should be supported.
>>>>>> Just wondering, is this platform dependent?
>>>>> this is for audio transmitting between the MRB and DIRANA (DSP).
>>>>> the DIRANA's scripts configure its ssp like this already.
>>>>> it is just for SSP2.
>>>> Then is this the right place to define it?
>>>>
>>>> Ranjani
>>> This sets the dynamic range of the channel number we can set.
>>> do you have any suggestion about this?
>>> I am not familiar with the m4 file's structure.
>> Hmm I am not too sure but maybe if you help me answer the question:
>> Does it makes sense to change it for all topologies(for other platforms
>> and SSP's)?
> I think multi-channel support is necessary for all other platform.
> for stereo or 4-channel or even more channel is depended on special case.
> but it is necessary to have this ability for each SSP port.

we should provide default settings in those helper .m4, if has different 
requirement(most of our cases actually) we should PCM_CAPABILITIES() to 
define specific PCM capabilities as we want, not only min/max channels, 
but all other params also.

Thanks,
~Keyon

> thanks
> ~zhigang
>>> ~zhigang
>>>>> thanks
>>>>> ~zhigang
>>>>>>> Signed-off-by: Wu Zhigang <zhigang.wu at linux.intel.com>
>>>>>>> Suggested-by: Keyon Jie <yang.jie at linux.intel.com>
>>>>>>> ---
>>>>>>>     topology/sof/pipe-volume-capture.m4  | 2 +-
>>>>>>>     topology/sof/pipe-volume-playback.m4 | 2 +-
>>>>>>>     2 files changed, 2 insertions(+), 2 deletions(-)
>>>>>>>
>>>>>>> diff --git a/topology/sof/pipe-volume-capture.m4
>>>>>>> b/topology/sof/pipe-
>>>>>>> volume-capture.m4
>>>>>>> index b3d3206..6b768e3 100644
>>>>>>> --- a/topology/sof/pipe-volume-capture.m4
>>>>>>> +++ b/topology/sof/pipe-volume-capture.m4
>>>>>>> @@ -66,5 +66,5 @@ indir(`define', concat(`PIPELINE_PCM_',
>>>>>>> PIPELINE_ID), Passthrough Capture PCM_ID
>>>>>>>     # PCM Configuration
>>>>>>>     #
>>>>>>> -PCM_CAPABILITIES(Passthrough Capture PCM_ID,
>>>>>>> `S32_LE,S24_LE,S16_LE',
>>>>>>> 48000, 48000, 2, 4, 2, 16, 192, 16384, 65536, 65536)
>>>>>>> +PCM_CAPABILITIES(Passthrough Capture PCM_ID,
>>>>>>> `S32_LE,S24_LE,S16_LE',
>>>>>>> 48000, 48000, 2, 8, 2, 16, 192, 16384, 65536, 65536)
>>>>>>> diff --git a/topology/sof/pipe-volume-playback.m4
>>>>>>> b/topology/sof/pipe-volume-playback.m4
>>>>>>> index 4b12d2a..f3203f7 100644
>>>>>>> --- a/topology/sof/pipe-volume-playback.m4
>>>>>>> +++ b/topology/sof/pipe-volume-playback.m4
>>>>>>> @@ -67,5 +67,5 @@ indir(`define', concat(`PIPELINE_PCM_',
>>>>>>> PIPELINE_ID), Passthrough Playback PCM_I
>>>>>>>     # PCM Configuration
>>>>>>>     #
>>>>>>> -PCM_CAPABILITIES(Passthrough Playback PCM_ID,
>>>>>>> `S32_LE,S24_LE,S16_LE', 48000, 48000, 2, 4, 2, 16, 192,
>>>>>>> 16384,
>>>>>>> 65536,
>>>>>>> 65536)
>>>>>>> +PCM_CAPABILITIES(Passthrough Playback PCM_ID,
>>>>>>> `S32_LE,S24_LE,S16_LE', 48000, 48000, 2, 8, 2, 16, 192,
>>>>>>> 16384,
>>>>>>> 65536,
>>>>>>> 65536)
>>>>> _______________________________________________
>>>>> Sound-open-firmware mailing list
>>>>> Sound-open-firmware at alsa-project.org
>>>>> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmw
>>>>> are
>>> _______________________________________________
>>> Sound-open-firmware mailing list
>>> Sound-open-firmware at alsa-project.org
>>> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
> 
> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware