[Sound-open-firmware] [PATCH V2 2/2] scripts: docker: Simplify docker build

[Liam Girdwood]

On Wed, 2018-06-06 at 12:06 +0800, Pan, Xiuli wrote:
> > > -RUN useradd --create-home -d /home/sof -u $UID -G sudo sof
> > > -RUN echo "sof:test0000" | chpasswd
> > > -RUN adduser sof sudo
> > > +# Set up sof user
> > > +RUN useradd --create-home -d /home/sof -u $UID -G sudo sof && \
> > > +echo "sof:test0000" | chpasswd && adduser sof sudo && echo '%sudo
> > > ALL=(ALL)
> > > NOPASSWD:ALL' >> /etc/sudoers
> > 
> > Does this mean rimage is installed on the Docker FS overlay with no password
> > now
> > ?
> 
> The rimage is installed every time when we run scripts/xtensa-build-all.sh.
> And the docker-run recommend to use scripts to build the sof. This 
> change just make sudo need no password in docker.
> The rimage install need sudo with password, either we change the scripts 
> or make sudo need no password.
> I just choose to use no password to make docker easier to use.


We can't compromise security. Maybe the easiest thing is to make xtensa-build.sh 
take a -l flag to install rimage to ~/bin and use this version.

Liam