[Sound-open-firmware] [PATCH] ipc: protect SOF_IPC_MESSAGE_ID macro parameters

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Mon Jun 4 18:46:53 CEST 2018


detected with checkpatch.pl --strict:
CHECK: Macro argument 'x' may be better as '(x)' to avoid precedence issues

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
---
 src/include/uapi/ipc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/include/uapi/ipc.h b/src/include/uapi/ipc.h
index 88de113..fc4ce46 100644
--- a/src/include/uapi/ipc.h
+++ b/src/include/uapi/ipc.h
@@ -126,7 +126,7 @@
 #define SOF_IPC_TRACE_DMA_POSITION		SOF_CMD_TYPE(0x002)
 
 /* Get message component id */
-#define SOF_IPC_MESSAGE_ID(x)			(x & 0xffff)
+#define SOF_IPC_MESSAGE_ID(x)			((x) & 0xffff)
 
 /* maximum message size for mailbox Tx/Rx */
 #define SOF_IPC_MSG_MAX_SIZE			128
-- 
2.14.1



More information about the Sound-open-firmware mailing list