[Sound-open-firmware] [PATCH 3/3] topology: test: Add loopback topology

[Pan, Xiuli]

On 6/4/2018 16:37, Liam Girdwood wrote:
> On Mon, 2018-06-04 at 14:39 +0800, Xiuli Pan wrote:
>> From: Pan Xiuli <xiuli.pan at linux.intel.com>
>>
>> Loopback topology will enable SSP DAI loopback mode. This can loopback
>> the SSP data.
>>
>> Signed-off-by: Pan Xiuli <xiuli.pan at linux.intel.com>
>> ---
>> Work with patch set:
>> SOF-Kernel:
>>    ASoC: SOF: upai: ipc: Add lbm in sof_ipc_dai_config
>>    ASoC: SOF: uapi: topology: Add SOF_TKN_DAI_LBM for ssp loopback mode
>>    ASoC: SOF: topology: Add topology handler for dai config loopback mode
>> SOF:
>>    uapi: ipc: Add lbm in sof_ipc_dai_config
>>    IPC: Add IPC handler for dai config loopback mode
>> SOF-Tools:
>>    topology: Add SOF_TKN_DAI_LBM for ssp loopback mode
>>    topology: m4: Add option for loopback mode in DAI config
>>    topology: test: Add loopback topology
>>
>> test & santity test with:
>> Mininow max rt5651 and UP2 Hifiberry PRO and CNL nocodec
>> SOF master: 65ddcddfcc9a20f5b622cf3ba93dc326387a9d5d
>> SOF-Tool master: 07d290c8ac6026af28bada021ac2215e3453fa88
>> https://github.com/plbossart/sound/tree/topic/sof-v4.14:
>> 3ffd39334cb53aced88b8aba17cae3df9ee2736f
>>
>> ---
>>   topology/test/test-loopback.m4 | 97
>> ++++++++++++++++++++++++++++++++++++++++++
>>   topology/test/tplg-build.sh    |  2 +-
>>   2 files changed, 98 insertions(+), 1 deletion(-)
>>   create mode 100644 topology/test/test-loopback.m4
>
> I want to see loopback added as a kcontrol switch type. Maybe the best way is to
> create a ssp.m4 that uses the existing DAI macros and also includes a kcontrol
> OR you could create a new DAI_KCONTROL macro ?
I was trying about kcontrol the whole last week.
I had a RFC thread named
[PTACH RFC 0/5] Add switch widget for loopback
Is this look good to you?

If the topology side looks OK, then I need to figure out how to bind the 
widget and get some kernel patch for the switch control alongside the 
volume kcontrol.
And I need continue to work with Ranjani to refine our controller IO 
handler.

Thanks
Xiuli


>
> Liam
> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware