[Sound-open-firmware] [PATCH] topology: test: fix m4 macro expansion for MCLK argument

Liam Girdwood liam.r.girdwood at linux.intel.com
Tue Jan 16 17:56:08 CET 2018


On Tue, 2018-01-16 at 10:37 -0600, Pierre-Louis Bossart wrote:
> M4 expands $10 as $1 followed by 0, so test .conf topology files contained
> mclk_freq "codec0" instead of the expected value (e.g. 19200000).
> 

m4 keeps same naming syntax for args > 9, but bash needs the {}

Applied and modified the commit message a little.

Liam

> Parenthesis are required when there are more than 9 arguments to a
> macro...



> 
> Reported-by: "Wang, Yan" <yan.wang at intel.com>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> ---
>  topology/test/tplg-build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/topology/test/tplg-build.sh b/topology/test/tplg-build.sh
> index 2392135..d322ce7 100755
> --- a/topology/test/tplg-build.sh
> +++ b/topology/test/tplg-build.sh
> @@ -39,7 +39,7 @@ function simple_test {
>  			-DTEST_SSP_FORMAT=$6 \
>  			-DTEST_PIPE_FORMAT=$4 \
>  			-DTEST_SSP_BCLK=$9 \
> -			-DTEST_SSP_MCLK=$10 \
> +			-DTEST_SSP_MCLK=${10} \
>  			-DTEST_SSP_PHY_BITS=$7 \
>  			-DTEST_SSP_DATA_BITS=$8 \
>  			$i.m4 > ${TFILE}.conf


More information about the Sound-open-firmware mailing list