[Sound-open-firmware] [PATCH 1/2] ASoc: SOF: Add memory window for all platform
Xiuli Pan
xiuli.pan at linux.intel.com
Mon Feb 12 07:20:01 CET 2018
From: Pan Xiuli <xiuli.pan at linux.intel.com>
Add memory window handler for BYT, HSW and BDW.
Signed-off-by: Pan Xiuli <xiuli.pan at linux.intel.com>
---
Test with:
Mininow max rt5651
SOF master: 5e60d064dbf9a5ab518cfa6fe79612bb49eee57a
SOF-Tool master: 57be4f5b8c96ba5839598046be4b4543ce8cf63b
https://github.com/plbossart/sound/tree/topic/sof-v4.14:
6fa721a8b7c6567eea0a2181bf9a3d2a12c31b00
---
sound/soc/sof/hw-apl.c | 15 ++++++---
sound/soc/sof/hw-bdw.c | 85 +++++++++++++++++++++++++++++++++++++++++++------
sound/soc/sof/hw-byt.c | 86 +++++++++++++++++++++++++++++++++++++++++++-------
sound/soc/sof/hw-hsw.c | 85 +++++++++++++++++++++++++++++++++++++++++++------
4 files changed, 236 insertions(+), 35 deletions(-)
diff --git a/sound/soc/sof/hw-apl.c b/sound/soc/sof/hw-apl.c
index 9100ae8..27e5704 100644
--- a/sound/soc/sof/hw-apl.c
+++ b/sound/soc/sof/hw-apl.c
@@ -1020,9 +1020,14 @@ static int apl_prepare(struct snd_sof_dev *sdev, unsigned int format,
static void apl_get_windows(struct snd_sof_dev *sdev)
{
struct sof_ipc_window_elem *elem;
+ u32 outbox_offset = 0;
+ u32 stream_offset = 0;
+ u32 inbox_offset = 0;
+ u32 outbox_size = 0;
+ u32 stream_size = 0;
+ u32 inbox_size = 0;
int i;
- u32 inbox_offset = 0, outbox_offset = 0;
- u32 inbox_size = 0, outbox_size = 0;
+
if (sdev->info_window == NULL)
return;
@@ -1061,9 +1066,11 @@ static void apl_get_windows(struct snd_sof_dev *sdev)
elem->size, "debug");
break;
case SOF_IPC_REGION_STREAM:
+ stream_offset =
+ elem->offset + SRAM_WINDOW_OFFSET(elem->id);
+ stream_size = elem->size;
snd_sof_debugfs_create_item(sdev,
- sdev->bar[APL_DSP_BAR] + elem->offset +
- SRAM_WINDOW_OFFSET(elem->id),
+ sdev->bar[APL_DSP_BAR] + stream_offset,
elem->size, "stream");
break;
case SOF_IPC_REGION_REGS:
diff --git a/sound/soc/sof/hw-bdw.c b/sound/soc/sof/hw-bdw.c
index cb59eb0..c51dba2 100644
--- a/sound/soc/sof/hw-bdw.c
+++ b/sound/soc/sof/hw-bdw.c
@@ -63,7 +63,6 @@ static const struct snd_sof_debugfs_map bdw_debugfs[] = {
{"iram", BDW_DSP_BAR, IRAM_OFFSET, BDW_IRAM_SIZE},
{"dram", BDW_DSP_BAR, DRAM_OFFSET, BDW_DRAM_SIZE},
{"shim", BDW_DSP_BAR, SHIM_OFFSET, SHIM_SIZE},
- {"mbox", BDW_DSP_BAR, MBOX_OFFSET, MBOX_SIZE},
};
/*
@@ -359,6 +358,75 @@ static irqreturn_t bdw_irq_thread(int irq, void *context)
/*
* IPC Firmware ready.
*/
+static void bdw_get_windows(struct snd_sof_dev *sdev)
+{
+ struct sof_ipc_window_elem *elem;
+ u32 outbox_offset = 0;
+ u32 stream_offset = 0;
+ u32 inbox_offset = 0;
+ u32 outbox_size = 0;
+ u32 stream_size = 0;
+ u32 inbox_size = 0;
+ int i;
+
+ if (sdev->info_window == NULL)
+ return;
+
+ for (i = 0; i < sdev->info_window->num_windows; i++) {
+
+ elem = &sdev->info_window->window[i];
+
+ switch (elem->type) {
+ case SOF_IPC_REGION_UPBOX:
+ inbox_offset = elem->offset + MBOX_OFFSET;
+ inbox_size = elem->size;
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[BDW_DSP_BAR] + inbox_offset,
+ elem->size, "inbox");
+ break;
+ case SOF_IPC_REGION_DOWNBOX:
+ outbox_offset = elem->offset + MBOX_OFFSET;
+ outbox_size = elem->size;
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[BDW_DSP_BAR] + outbox_offset,
+ elem->size, "outbox");
+ break;
+ case SOF_IPC_REGION_TRACE:
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[BDW_DSP_BAR] + elem->offset +
+ MBOX_OFFSET, elem->size, "etrace");
+ break;
+ case SOF_IPC_REGION_DEBUG:
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[BDW_DSP_BAR] + elem->offset +
+ MBOX_OFFSET, elem->size, "debug");
+ break;
+ case SOF_IPC_REGION_STREAM:
+ stream_offset = elem->offset + MBOX_OFFSET;
+ stream_size = elem->size;
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[BDW_DSP_BAR] + stream_offset,
+ elem->size, "stream");
+ break;
+ case SOF_IPC_REGION_REGS:
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[BDW_DSP_BAR] + elem->offset +
+ MBOX_OFFSET, elem->size, "regs");
+ break;
+ default:
+ break;
+ }
+ }
+
+ snd_sof_dsp_mailbox_init(sdev, inbox_offset, inbox_size,
+ outbox_offset, outbox_size);
+
+ dev_dbg(sdev->dev, " mailbox upstream 0x%x - size 0x%x\n",
+ inbox_offset, inbox_size);
+ dev_dbg(sdev->dev, " mailbox downstream 0x%x - size 0x%x\n",
+ outbox_offset, outbox_size);
+}
+
static int bdw_fw_ready(struct snd_sof_dev *sdev, u32 msg_id)
{
struct sof_ipc_fw_ready *fw_ready = &sdev->fw_ready;
@@ -374,18 +442,15 @@ static int bdw_fw_ready(struct snd_sof_dev *sdev, u32 msg_id)
/* copy data from the DSP FW ready offset */
bdw_block_read(sdev, offset, fw_ready, sizeof(*fw_ready));
- snd_sof_dsp_mailbox_init(sdev, fw_ready->dspbox_offset,
- fw_ready->dspbox_size, fw_ready->hostbox_offset,
- fw_ready->hostbox_size);
-
- dev_dbg(sdev->dev, " mailbox DSP initiated 0x%x - size 0x%x\n",
- fw_ready->dspbox_offset, fw_ready->dspbox_size);
- dev_dbg(sdev->dev, " mailbox Host initiated 0x%x - size 0x%x\n",
- fw_ready->hostbox_offset, fw_ready->hostbox_size);
-
dev_info(sdev->dev, " Firmware info: version %d:%d-%s build %d on %s:%s\n",
v->major, v->minor, v->tag, v->build, v->date, v->time);
+ /* now check for extended data */
+ snd_sof_fw_parse_ext_data(sdev,
+ MBOX_OFFSET + sizeof(struct sof_ipc_fw_ready));
+
+ bdw_get_windows(sdev);
+
return 0;
}
diff --git a/sound/soc/sof/hw-byt.c b/sound/soc/sof/hw-byt.c
index fab5c06..d36a0f6 100644
--- a/sound/soc/sof/hw-byt.c
+++ b/sound/soc/sof/hw-byt.c
@@ -74,7 +74,6 @@ static const struct snd_sof_debugfs_map byt_debugfs[] = {
{"iram", BYT_DSP_BAR, IRAM_OFFSET, IRAM_SIZE},
{"dram", BYT_DSP_BAR, DRAM_OFFSET, DRAM_SIZE},
{"shim", BYT_DSP_BAR, SHIM_OFFSET, SHIM_SIZE},
- {"mbox", BYT_DSP_BAR, MBOX_OFFSET, MBOX_SIZE},
};
static const struct snd_sof_debugfs_map cht_debugfs[] = {
@@ -90,7 +89,6 @@ static const struct snd_sof_debugfs_map cht_debugfs[] = {
{"iram", BYT_DSP_BAR, IRAM_OFFSET, IRAM_SIZE},
{"dram", BYT_DSP_BAR, DRAM_OFFSET, DRAM_SIZE},
{"shim", BYT_DSP_BAR, SHIM_OFFSET, SHIM_SIZE},
- {"mbox", BYT_DSP_BAR, MBOX_OFFSET, MBOX_SIZE},
};
static void byt_dump(struct snd_sof_dev *sdev, u32 flags)
@@ -202,6 +200,75 @@ static void byt_block_read(struct snd_sof_dev *sdev, u32 offset, void *dest,
/*
* IPC Firmware ready.
*/
+static void byt_get_windows(struct snd_sof_dev *sdev)
+{
+ struct sof_ipc_window_elem *elem;
+ u32 outbox_offset = 0;
+ u32 stream_offset = 0;
+ u32 inbox_offset = 0;
+ u32 outbox_size = 0;
+ u32 stream_size = 0;
+ u32 inbox_size = 0;
+ int i;
+
+ if (sdev->info_window == NULL)
+ return;
+
+ for (i = 0; i < sdev->info_window->num_windows; i++) {
+
+ elem = &sdev->info_window->window[i];
+
+ switch (elem->type) {
+ case SOF_IPC_REGION_UPBOX:
+ inbox_offset = elem->offset + MBOX_OFFSET;
+ inbox_size = elem->size;
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[BYT_DSP_BAR] + inbox_offset,
+ elem->size, "inbox");
+ break;
+ case SOF_IPC_REGION_DOWNBOX:
+ outbox_offset = elem->offset + MBOX_OFFSET;
+ outbox_size = elem->size;
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[BYT_DSP_BAR] + outbox_offset,
+ elem->size, "outbox");
+ break;
+ case SOF_IPC_REGION_TRACE:
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[BYT_DSP_BAR] + elem->offset +
+ MBOX_OFFSET, elem->size, "etrace");
+ break;
+ case SOF_IPC_REGION_DEBUG:
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[BYT_DSP_BAR] + elem->offset +
+ MBOX_OFFSET, elem->size, "debug");
+ break;
+ case SOF_IPC_REGION_STREAM:
+ stream_offset = elem->offset + MBOX_OFFSET;
+ stream_size = elem->size;
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[BYT_DSP_BAR] + stream_offset,
+ elem->size, "stream");
+ break;
+ case SOF_IPC_REGION_REGS:
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[BYT_DSP_BAR] + elem->offset +
+ MBOX_OFFSET, elem->size, "regs");
+ break;
+ default:
+ break;
+ }
+ }
+
+ snd_sof_dsp_mailbox_init(sdev, inbox_offset, inbox_size,
+ outbox_offset, outbox_size);
+
+ dev_dbg(sdev->dev, " mailbox upstream 0x%x - size 0x%x\n",
+ inbox_offset, inbox_size);
+ dev_dbg(sdev->dev, " mailbox downstream 0x%x - size 0x%x\n",
+ outbox_offset, outbox_size);
+}
+
static int byt_fw_ready(struct snd_sof_dev *sdev, u32 msg_id)
{
struct sof_ipc_fw_ready *fw_ready = &sdev->fw_ready;
@@ -217,18 +284,15 @@ static int byt_fw_ready(struct snd_sof_dev *sdev, u32 msg_id)
/* copy data from the DSP FW ready offset */
byt_block_read(sdev, offset, fw_ready, sizeof(*fw_ready));
- snd_sof_dsp_mailbox_init(sdev, fw_ready->dspbox_offset,
- fw_ready->dspbox_size, fw_ready->hostbox_offset,
- fw_ready->hostbox_size);
-
- dev_dbg(sdev->dev, " mailbox DSP initiated 0x%x - size 0x%x\n",
- fw_ready->dspbox_offset, fw_ready->dspbox_size);
- dev_dbg(sdev->dev, " mailbox Host initiated 0x%x - size 0x%x\n",
- fw_ready->hostbox_offset, fw_ready->hostbox_size);
-
dev_info(sdev->dev, " Firmware info: version %d:%d-%s build %d on %s:%s\n",
v->major, v->minor, v->tag, v->build, v->date, v->time);
+ /* now check for extended data */
+ snd_sof_fw_parse_ext_data(sdev,
+ MBOX_OFFSET + sizeof(struct sof_ipc_fw_ready));
+
+ byt_get_windows(sdev);
+
return 0;
}
diff --git a/sound/soc/sof/hw-hsw.c b/sound/soc/sof/hw-hsw.c
index f7cafdc..615411c 100644
--- a/sound/soc/sof/hw-hsw.c
+++ b/sound/soc/sof/hw-hsw.c
@@ -65,7 +65,6 @@ static const struct snd_sof_debugfs_map hsw_debugfs[] = {
{"iram", HSW_DSP_BAR, IRAM_OFFSET, HSW_IRAM_SIZE},
{"dram", HSW_DSP_BAR, DRAM_OFFSET, HSW_DRAM_SIZE},
{"shim", HSW_DSP_BAR, SHIM_OFFSET, SHIM_SIZE},
- {"mbox", HSW_DSP_BAR, MBOX_OFFSET, MBOX_SIZE},
};
/*
@@ -384,6 +383,75 @@ static irqreturn_t hsw_irq_thread(int irq, void *context)
/*
* IPC Firmware ready.
*/
+static void hsw_get_windows(struct snd_sof_dev *sdev)
+{
+ struct sof_ipc_window_elem *elem;
+ u32 outbox_offset = 0;
+ u32 stream_offset = 0;
+ u32 inbox_offset = 0;
+ u32 outbox_size = 0;
+ u32 stream_size = 0;
+ u32 inbox_size = 0;
+ int i;
+
+ if (sdev->info_window == NULL)
+ return;
+
+ for (i = 0; i < sdev->info_window->num_windows; i++) {
+
+ elem = &sdev->info_window->window[i];
+
+ switch (elem->type) {
+ case SOF_IPC_REGION_UPBOX:
+ inbox_offset = elem->offset + MBOX_OFFSET;
+ inbox_size = elem->size;
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[HSW_DSP_BAR] + inbox_offset,
+ elem->size, "inbox");
+ break;
+ case SOF_IPC_REGION_DOWNBOX:
+ outbox_offset = elem->offset + MBOX_OFFSET;
+ outbox_size = elem->size;
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[HSW_DSP_BAR] + outbox_offset,
+ elem->size, "outbox");
+ break;
+ case SOF_IPC_REGION_TRACE:
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[HSW_DSP_BAR] + elem->offset +
+ MBOX_OFFSET, elem->size, "etrace");
+ break;
+ case SOF_IPC_REGION_DEBUG:
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[HSW_DSP_BAR] + elem->offset +
+ MBOX_OFFSET, elem->size, "debug");
+ break;
+ case SOF_IPC_REGION_STREAM:
+ stream_offset = elem->offset + MBOX_OFFSET;
+ stream_size = elem->size;
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[HSW_DSP_BAR] + stream_offset,
+ elem->size, "stream");
+ break;
+ case SOF_IPC_REGION_REGS:
+ snd_sof_debugfs_create_item(sdev,
+ sdev->bar[HSW_DSP_BAR] + elem->offset +
+ MBOX_OFFSET, elem->size, "regs");
+ break;
+ default:
+ break;
+ }
+ }
+
+ snd_sof_dsp_mailbox_init(sdev, inbox_offset, inbox_size,
+ outbox_offset, outbox_size);
+
+ dev_dbg(sdev->dev, " mailbox upstream 0x%x - size 0x%x\n",
+ inbox_offset, inbox_size);
+ dev_dbg(sdev->dev, " mailbox downstream 0x%x - size 0x%x\n",
+ outbox_offset, outbox_size);
+}
+
static int hsw_fw_ready(struct snd_sof_dev *sdev, u32 msg_id)
{
struct sof_ipc_fw_ready *fw_ready = &sdev->fw_ready;
@@ -399,18 +467,15 @@ static int hsw_fw_ready(struct snd_sof_dev *sdev, u32 msg_id)
/* copy data from the DSP FW ready offset */
hsw_block_read(sdev, offset, fw_ready, sizeof(*fw_ready));
- snd_sof_dsp_mailbox_init(sdev, fw_ready->dspbox_offset,
- fw_ready->dspbox_size, fw_ready->hostbox_offset,
- fw_ready->hostbox_size);
-
- dev_dbg(sdev->dev, " mailbox DSP initiated 0x%x - size 0x%x\n",
- fw_ready->dspbox_offset, fw_ready->dspbox_size);
- dev_dbg(sdev->dev, " mailbox Host initiated 0x%x - size 0x%x\n",
- fw_ready->hostbox_offset, fw_ready->hostbox_size);
-
dev_info(sdev->dev, " Firmware info: version %d:%d-%s build %d on %s:%s\n",
v->major, v->minor, v->tag, v->build, v->date, v->time);
+ /* now check for extended data */
+ snd_sof_fw_parse_ext_data(sdev,
+ MBOX_OFFSET + sizeof(struct sof_ipc_fw_ready));
+
+ hsw_get_windows(sdev);
+
return 0;
}
--
2.7.4
More information about the Sound-open-firmware
mailing list