[Sound-open-firmware] [PATCH] apl-ssp: fix padding bit issues in I2S/LEFT_J mode

Jie, Yang yang.jie at intel.com
Fri Apr 13 16:48:31 CEST 2018



>-----Original Message-----
>From: Pierre-Louis Bossart [mailto:pierre-louis.bossart at linux.intel.com]
>Sent: Friday, April 13, 2018 10:19 PM
>To: Jie, Yang <yang.jie at intel.com>; sound-open-firmware at alsa-project.org
>Subject: Re: [Sound-open-firmware] [PATCH] apl-ssp: fix padding bit issues in
>I2S/LEFT_J mode
>
>
>>> +		sspsp |= SSPSP_EDMYSTOP((slot_end_padding >> 2) & 0x3);
>>> +		sspsp |= SSPSP_DMYSTOP(slot_end_padding & 0x3);
>>
>> We have already macros for those masks, just sent you a patch which you can
>combine with.
>
>Did you mean this?

Yep.

Thanks,
~Keyon

>
>+	sspsp |= SSPSP_DMYSTOP(SSPSP_DMYSTOP_MASK & dummy_stop);
>+	sspsp |= SSPSP_EDMYSTOP(SSPSP_EDMYSTOP_MASK &
>+				(dummy_stop >> SSPSP_DMYSTOP_BITS));



More information about the Sound-open-firmware mailing list