[Sound-open-firmware] [PATCH 00/10] MISRA rules - 1st pass

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Mon Sep 25 21:52:08 CEST 2017


here are a set of patches that start a cleanup for MISRA compliance
required for automotive. In general while the MISRA rules are
debatable, they helped point at code that can be optimized or made
more readable.

Additional information on remaining opens can be seen here:
https://sonarcloud.io/project/issues?directories=src%2Farch%2Fxtensa%2Csrc%2Faudio%2Csrc%2Fdrivers%2Csrc%2Finclude%2Freef%2Csrc%2Finclude%2Freef%2Faudio%2Csrc%2Finclude%2Fuapi%2Csrc%2Fipc%2Csrc%2Flib%2Csrc%2Fmath%2Csrc%2Fplatform%2Fbaytrail&id=sound-open-firmware&resolved=false&tags=misra

Pierre-Louis Bossart (10):
  sof: define each identifier in a dedicated statement
  pipeline: add missing default case
  pipeline: simplify prepare loop
  SRC: replace switch by if for readability
  tone: replace switch by if for readability
  volume: replace switch by if for readability
  ssp: replace switch by if for readability
  ssp: remove unnecessary direction parameter in ssp_stop
  wait: reduce number of nested breaks
  ipc: remove unnecessary tests

 src/arch/xtensa/timer.c          |  9 ++++--
 src/audio/dai.c                  | 17 ++++++----
 src/audio/eq_fir.c               | 22 ++++++++++---
 src/audio/eq_iir.c               | 21 +++++++++---
 src/audio/host.c                 | 17 +++++++---
 src/audio/iir.c                  |  6 ++--
 src/audio/mixer.c                | 15 ++++++---
 src/audio/pipeline.c             | 26 +++++++--------
 src/audio/pipeline_static.c      |  5 ++-
 src/audio/src.c                  | 38 ++++++++++++++--------
 src/audio/src_core.c             | 42 ++++++++++++++++++------
 src/audio/tone.c                 | 24 +++++++-------
 src/audio/volume.c               | 69 +++++++++++++++++++++++-----------------
 src/drivers/dw-dma.c             | 15 ++++++---
 src/drivers/ssp.c                | 24 ++++++++------
 src/include/reef/wait.h          |  4 +--
 src/ipc/byt-ipc.c                |  5 +--
 src/ipc/dma-copy.c               | 14 +++++---
 src/ipc/intel-ipc.c              |  9 ++++--
 src/ipc/ipc.c                    |  3 +-
 src/ipc/pmc-ipc.c                |  6 ++--
 src/lib/alloc.c                  | 24 ++++++++++----
 src/lib/lib.c                    | 17 +++++++---
 src/lib/schedule.c               | 13 +++++---
 src/lib/work.c                   | 18 ++++++++---
 src/math/trig.c                  |  8 +++--
 src/platform/baytrail/clk.c      |  3 +-
 src/platform/baytrail/platform.c | 18 ++++++++---
 src/platform/baytrail/timer.c    |  8 +++--
 29 files changed, 334 insertions(+), 166 deletions(-)

-- 
2.11.0



More information about the Sound-open-firmware mailing list