[Sound-open-firmware] [PATCH] component: host: add error trace for elem errors

Liam Girdwood liam.r.girdwood at linux.intel.com
Thu Oct 12 23:31:10 CEST 2017


Also place a TODO for future improvement.

Signed-off-by: Liam Girdwood <liam.r.girdwood at linux.intel.com>
---
 src/audio/host.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/audio/host.c b/src/audio/host.c
index 14a77d4..3c77aca 100644
--- a/src/audio/host.c
+++ b/src/audio/host.c
@@ -315,6 +315,7 @@ static int create_local_elems(struct comp_dev *dev)
 	struct list_item *tlist;
 	int i;
 
+	/* TODO: simplify elem storage by using an array */
 	for (i = 0; i < hd->period_count; i++) {
 		/* allocate new host DMA elem and add it to our list */
 		e = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, sizeof(*e));
@@ -337,11 +338,11 @@ static int create_local_elems(struct comp_dev *dev)
 
 unwind:
 	list_for_item_safe(elist, tlist, &hd->local.elem_list) {
-
 		e = container_of(elist, struct dma_sg_elem, list);
 		list_item_del(&e->list);
 		rfree(e);
 	}
+	trace_host_error("el0");
 	return -ENOMEM;
 }
 
-- 
2.11.0



More information about the Sound-open-firmware mailing list