[Sound-open-firmware] [PATCH 2/4] Tone: Add channel specific volume plus other fixes

[Liam Girdwood]

On Thu, 2017-06-22 at 14:50 +0300, Seppo Ingalsuo wrote:
> Thanks, that works. At least with the compiler that I use 
> (http://alsa-project.org/main/index.php/Firmware) the optimizing does 
> the conversion to fixed without increase of the firmware image size.
> I 
> also checked from disassembly that this part of the code remains 
> identical. I did a minor fix and added rounding into the macro since 
> compiler doesn't round the cast to int:
> 
> #define TONE_FREQ(f)    (int)((f) * (1 << 16))    /* f = float */
> 
> #define TONE_FREQ(f)    (((int)((f) * (1 << 17)) + 1) >> 1)  /* f =
> float */
> 
> If there's no concern from other people who know better the compilers 
> I'm OK to make this change to increase readability and help avoiding 
> mistakes with frequencies.


Ok, by me.

Liam