[Sound-open-firmware] [PATCH v2 00/26] add R/W pointers check for pipeline buffers

Jie, Yang yang.jie at intel.com
Sat Feb 11 03:04:41 CET 2017


> -----Original Message-----
> From: Liam Girdwood [mailto:liam.r.girdwood at linux.intel.com]
> Sent: Saturday, February 11, 2017 12:08 AM
> To: Keyon Jie <yang.jie at linux.intel.com>
> Cc: sound-open-firmware at alsa-project.org; Jie, Yang <yang.jie at intel.com>;
> Ingalsuo, Seppo <seppo.ingalsuo at intel.com>
> Subject: Re: [PATCH v2 00/26] add R/W pointers check for pipeline buffers
> 
> On Thu, 2017-02-09 at 23:03 +0800, Keyon Jie wrote:
> > This series adding the R/W buffer pointers check and make sure we
> > won't copy wrong/missed/repeated data for the whole pipeline.
> >
> > For ALSA applications, usually we have two kinds of trigger command
> sequences:
> > 1. (e.g. aplay) prefill datas ==> trigger start ==> refill buffer(when buffer
> >         free is enough) ==> ... ==> data filling finished ==> trigger drain ==>
> >         when all datas are rendered(via read pointer feedback) ==>
> > trigger stop; 2. (e.g. speaker-test with large buffer size > wav file size):
> >         prefill all datas one time ==> trigger start ==> wait until all datas are
> >         rendered(via feedback read pointer) ==> trigger stop ==> prefill another
> >         wav file ==> trigger start ==> ...
> >
> 
> Keyon, this is not applying on top of master. Maybe something in your rebase ?
> 
> Can you fix and I'll then pull in your branch.

That looks somewhat strange, it applied on top of master on my side
(based on commit 1659269bfa08fdc52b4139b8984b70139b6f3dd8).

Anyway, let me send my latest v3(one preload patch added) which should
work.

Thanks,
~Keyon

> 
> Thanks
> 
> Liam



More information about the Sound-open-firmware mailing list