[Sound-open-firmware] [PATCH] byt-ipc: add msg back to empty_list for next use

[Jie, Yang]

>-----Original Message-----
>From: Girdwood, Liam R
>Sent: Monday, December 11, 2017 10:59 PM
>To: Keyon Jie <yang.jie at linux.intel.com>; sound-open-firmware at alsa-
>project.org
>Cc: Jie, Yang <yang.jie at intel.com>; Wang, Yan <yan.wang at intel.com>
>Subject: Re: [Sound-open-firmware] [PATCH] byt-ipc: add msg back to empty_list
>for next use
>
>On Mon, 2017-12-11 at 21:31 +0800, Keyon Jie wrote:
>> The msg pool will be used up as it was not added back to empty_list,
>> here correct it.
>>
>> Signed-off-by: Keyon Jie <yang.jie at linux.intel.com>
>> ---
>>  src/ipc/byt-ipc.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/src/ipc/byt-ipc.c b/src/ipc/byt-ipc.c index
>> 8897bb9..6716cce 100644
>> --- a/src/ipc/byt-ipc.c
>> +++ b/src/ipc/byt-ipc.c
>> @@ -194,6 +194,9 @@ void ipc_platform_send_msg(struct ipc *ipc)
>>  	shim_write(SHIM_IPCDL, msg->header);
>>  	shim_write(SHIM_IPCDH, SHIM_IPCDH_BUSY);
>>
>> +	/* add msg back to empty_list for next use */
>> +	list_item_append(&msg->list, &ipc->empty_list);
>
>This should be returned to the free pool in do_notify() ?

I believe not all DSP initiated msg has ack from host? Or notify() is
used seldom? I have blurry memory about this, but at least we can
replace the one in do_notify() with this one?

Thanks,
~Keyon

>
>> +
>>  out:
>>  	spin_unlock_irq(&ipc->lock, flags);
>>  }