[Sound-open-firmware] [PATCH] bvt: clk: Fix clock lookup table

[Liam Girdwood]

On Mon, 2017-12-04 at 21:51 -0600, Pierre-Louis Bossart wrote:
> 
> On 12/04/2017 02:16 PM, Liam Girdwood wrote:
> > Baytrail clock lookup has wrong ticks per MHz values for 19.2M.
> > Fix.
> > 
> > Signed-off-by: Liam Girdwood <liam.r.girdwood at linux.intel.com>
> > ---
> >   src/platform/baytrail/clk.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/platform/baytrail/clk.c
> > b/src/platform/baytrail/clk.c
> > index eac64c3..b616eff 100644
> > --- a/src/platform/baytrail/clk.c
> > +++ b/src/platform/baytrail/clk.c
> > @@ -67,8 +67,8 @@ static struct clk_pdata *clk_pdata;
> >   #if defined CONFIG_BAYTRAIL
> >   /* increasing frequency order */
> >   static const struct freq_table cpu_freq[] = {
> > -	{19200000, 25, 0x0},
> > -	{19200000, 25, 0x1},
> > +	{19200000, 19, 0x0},
> > +	{19200000, 19, 0x1},
> >   	{38400000, 50, 0x2},
> 
> are you sure about this?
> I double-checked in the HAS and the only thing which is related to
> 19.2 
> is the SSP clock, this is unrelated to the cpu_frequency.
> 
> this table should be
> 
> diff --git a/src/platform/baytrail/clk.c
> b/src/platform/baytrail/clk.c
> index eac64c3..b972aed 100644
> --- a/src/platform/baytrail/clk.c
> +++ b/src/platform/baytrail/clk.c
> @@ -67,9 +67,9 @@ static struct clk_pdata *clk_pdata;
>   #if defined CONFIG_BAYTRAIL
>   /* increasing frequency order */
>   static const struct freq_table cpu_freq[] = {
> -       {19200000, 25, 0x0},
> -       {19200000, 25, 0x1},
> -       {38400000, 50, 0x2},
> +       {25000000, 25, 0x0},
> +       {25000000, 25, 0x1},
> +       {50000000, 50, 0x2},
>          {50000000, 50, 0x3},    /* default */
>          {100000000, 100, 0x4},
>          {200000000, 200, 0x5},
> 
> >   	{50000000, 50, 0x3},	/* default */
> >   	{100000000, 100, 0x4},
> 

Yep, doubled checked that now and the CHT HAS too. So the original was
correct wrt ticks per MHz, but wrong with clock. Both clocks are XTAL.

Fix in V2.

Liam