[Sound-open-firmware] [PATCH] git-version: Fix REEF_TAG bug when having rc tags

[Pan, Xiuli]

Hi Liam,

I cut the commit to fit the size in FW. I will ask Zhigang about this.
I also have some idea about insert more info in the FW info to make debug easier.

Thanks
Xiuli
>-----Original Message-----
>From: Liam Girdwood [mailto:liam.r.girdwood at linux.intel.com]
>Sent: Tuesday, December 5, 2017 15:13
>To: Pan, Xiuli <xiuli.pan at intel.com>; Keyon Jie <yang.jie at linux.intel.com>; Xiuli
>Pan <xiuli.pan at linux.intel.com>; sound-open-firmware at alsa-project.org
>Subject: Re: [Sound-open-firmware] [PATCH] git-version: Fix REEF_TAG bug when
>having rc tags
>
>On Tue, 2017-12-05 at 03:21 +0000, Pan, Xiuli wrote:
>> OK, here is a example
>> Before as for RC2 branch:
>> git describe --abbrev=4 will get
>> v1.0-rc2-1-gf310 ( g here means git to show we use git as code
>> manager in case svn or other tools are used we may not need this)
>> git describe --abbrev=4 | cut -d- -f3 will get
>> 1 ( this 1 means 1 more commit is added since the rc2 tag)
>> As we add a '-rc2' in the tag, this cut script detect with '-' will
>> fail with hard code -f3, in this case we need -f4 to get the real
>> commit tag.
>>
>> If we just get the log commit hash id with
>> git log --pretty=format:%h -1 | cut -c1-5
>> we get
>> f3106
>>
>> This can work when any tag is set for the git repo.
>>
>
>Ok, you may also need to increase the size of the FW version string too
>as part of this patch (including the kernel IPC header too).
>
>Liam