[Sound-open-firmware] [PATCH] platform: baytrail: use package string as the fw version

Keyon Jie yang.jie at linux.intel.com
Thu Oct 27 10:20:11 CEST 2016



On 2016年10月27日 15:16, Liam Girdwood wrote:
> On Thu, 2016-10-27 at 14:53 +0800, Keyon Jie wrote:
>> use the package string, which come from git version, as the
>> fw version.
>>
>
> Can you say why we should use this version in the commit message.

something like that 'it provide more information of the detail version'?

~Keyon

>
> Thanks
>
> Liam
>
>> Signed-off-by: Keyon Jie <yang.jie at linux.intel.com>
>> ---
>>   src/platform/baytrail/platform.c | 6 +-----
>>   1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/src/platform/baytrail/platform.c b/src/platform/baytrail/platform.c
>> index 36d4993..ea3828f 100644
>> --- a/src/platform/baytrail/platform.c
>> +++ b/src/platform/baytrail/platform.c
>> @@ -57,11 +57,7 @@ static const struct sst_intel_ipc_fw_ready ready = {
>>   	.outbox_size = MAILBOX_INBOX_SIZE,
>>   	.fw_info_size = sizeof(struct fw_info),
>>   	{
>> -		.info = {
>> -			.name = "REEF",
>> -			.date = __DATE__,
>> -			.time = __TIME__,
>> -		},
>> +		.rsvd = PACKAGE_STRING,
>>   	},
>>   };
>>
>
>
>


More information about the Sound-open-firmware mailing list