[Sound-open-firmware] [PATCH v2 4/7] ssp: switch dai format form PCM B mode to normal I2S mode

[Jie, Yang]

> -----Original Message-----
> From: Liam Girdwood [mailto:liam.r.girdwood at linux.intel.com]
> Sent: Thursday, December 22, 2016 7:21 PM
> To: Keyon Jie <yang.jie at linux.intel.com>
> Cc: sound-open-firmware at alsa-project.org; Zhang, Keqiao
> <keqiao.zhang at intel.com>; Jie, Yang <yang.jie at intel.com>; Ingalsuo, Seppo
> <seppo.ingalsuo at intel.com>; Lin, Mengdong <mengdong.lin at intel.com>
> Subject: Re: [Sound-open-firmware] [PATCH v2 4/7] ssp: switch dai format form
> PCM B mode to normal I2S mode
> 
> On Thu, 2016-12-22 at 17:27 +0800, Keyon Jie wrote:
> > it is configured from host/codec side that using I2S mode, so switch
> > it.
> > ---
> >  src/ipc/intel-ipc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/ipc/intel-ipc.c b/src/ipc/intel-ipc.c index
> > 1fdd73f..8d33830 100644
> > --- a/src/ipc/intel-ipc.c
> > +++ b/src/ipc/intel-ipc.c
> > @@ -561,7 +561,7 @@ static uint32_t ipc_device_set_formats(uint32_t
> > header)
> >
> >  	/* setup the DAI HW config - TODO hard coded due to IPC limitations */
> >  	dai_dev->dai_config.mclk = config_req.clock_frequency;
> > -	dai_dev->dai_config.format = DAI_FMT_DSP_B | DAI_FMT_CONT |
> > +	dai_dev->dai_config.format = DAI_FMT_I2S | DAI_FMT_CONT |
> >  		DAI_FMT_NB_NF | DAI_FMT_CBS_CFS;
> >  	dai_dev->dai_config.frame_size = 32;	/* TODO 16bit stereo hard
> coded */
> >  	dai_dev->dai_config.bclk_fs = 32;	/* 32 BCLKs per frame - */
> 
> 
> Ok, so this is to match the existing upstream machine drivers ?  We do need to
> revisit this so it can be programmed at runtime.

Yes, and we already adding programmable in patch 5/7.

Thanks,
~Keyon

> 
> Liam