[PATCH 1/1] ASoC: fsl_sai: Use dev_err_probe

[Shengjiu Wang]

On Thu, Jan 12, 2023 at 12:11 AM Alexander Stein <
alexander.stein at ew.tq-group.com> wrote:

> This helps figuring out why the device probe is deferred, e.g. missing
> FSL_EDMA driver.
>
> Signed-off-by: Alexander Stein <alexander.stein at ew.tq-group.com>
>

Acked-by: Shengjiu Wang <shengjiu.wang at gmail.com>

Best regards
Wang Shengjiu

> ---
> Old:
> root at ls1021:~# cat /sys/kernel/debug/devices_deferred
> sound   fsl-asoc-card: snd_soc_register_card failed: -517
> 2b50000.sai
>
> New:
> root at ls1021:~# cat /sys/kernel/debug/devices_deferred
> sound   fsl-asoc-card: snd_soc_register_card failed: -517
> 2b50000.sai     fsl-sai: Registering PCM dmaengine failed
>
>  sound/soc/fsl/fsl_sai.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 1c9be8a5dcb13..2a38e2bdf9893 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -1458,14 +1458,17 @@ static int fsl_sai_probe(struct platform_device
> *pdev)
>         if (sai->soc_data->use_imx_pcm) {
>                 ret = imx_pcm_dma_init(pdev);
>                 if (ret) {
> +                       dev_err_probe(dev, ret, "PCM DMA init failed\n");
>                         if (!IS_ENABLED(CONFIG_SND_SOC_IMX_PCM_DMA))
>                                 dev_err(dev, "Error: You must enable the
> imx-pcm-dma support!\n");
>                         goto err_pm_get_sync;
>                 }
>         } else {
>                 ret = devm_snd_dmaengine_pcm_register(dev, NULL, 0);
> -               if (ret)
> +               if (ret) {
> +                       dev_err_probe(dev, ret, "Registering PCM dmaengine
> failed\n");
>                         goto err_pm_get_sync;
> +               }
>         }
>
>         ret = devm_snd_soc_register_component(dev, &fsl_component,
> --
> 2.34.1
>
>