[PATCH v2] ucm: add existence checks to geti calls

Curtis Malainey cujomalainey at google.com
Fri Jan 13 20:36:32 CET 2023


On Fri, Jan 13, 2023 at 11:32 AM Jaroslav Kysela <perex at perex.cz> wrote:
>
> On 13. 01. 23 19:50, cujomalainey at chromium.org wrote:
> > From: Curtis Malainey <cujomalainey at chromium.org>
> >
> > Right now in snd_use_case_geti you cannot tell if the item being queried
> > exists or not when being checked. This also means the only way to check
> > for the existence of something in the client of the library is to
> > iterate over the list of mods/devs even if we know exactly the name we
> > are looking for. We have functions that do exactly this internally so
> > lets return this information in a logical fashion through geti.
>
> The device_status/modifier_status functions are used internally, too.
> I would add the device validation only to the geti code. The other parts do
> this job already and expect just 0 or 1 return values.
>
>                                 Jaroslav

Understood, I will move it back to geti directly, figured this was the
cleanest place to put it but that makes sense if other places use
those internal functions.

>
> --
> Jaroslav Kysela <perex at perex.cz>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.


More information about the Alsa-devel mailing list