[PATCH 14/14] Fixed the retry_cnt bug about being zero

[Ki-Seok Jo]

> On Mon, Jan 09, 2023 at 07:33:19AM +0000, Ki-Seok Jo wrote:
> > 
> > >On Fri, Jan 06, 2023 at 09:55:43AM +0000, Ki-Seok Jo wrote:
> > > > 
> > > > Hi Dan,
> > > > 
> > > > I'm sorry. There was an opinion that the pach sent last time was inconvenient to look at because the entire patch aws modified at once.
> > > > 
> > 
> > > What you should have done was just fold everything into two patches:
> > > patch 1: add the driver
> > > patch 2: add the device tree bindings
> > 
> > > Instead you did:
> > > patch 1: add the driver
> > > patch 2: add the device tree bindings patch 3: re-write all of patch 
> > > 1.
> > 
> > > Re-writing everything is not allowed, but it's also not necessary.  And also it is against the rules to submit broken code and fix it later.
> > 
> > > It's a new driver so just fix patch 1 and resend that as a v2 patch.
> > > Same for the stuff I mentioned in my bug report.
> > 
> > > https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-pat
> > > ch/
> > 
> > > regards,
> > > dan carpenter
> > 
> > 
> > Thank you for your kindly advise. I read your report and it was very helpful.
> > As I understand, I already sent it the wrong way. So I want to pick up the pieces.
> > 
> > First, I already sent the new driver code a few months ago.
> > After that, I got several feedbacks.
> > I've edit and test it. So a lot of things changed at once.
> > 
> > Since I changed so many things, I didn't know what to do, so I just updated it as a patch.
> > It's my mistake...
> > 
> > So I already sent about patch 1 and 2, if I get the feedback, should I 
> > send a lot of changes as v2 patch?(not patch 3) For each change, should I send patch log per commit?
> > 
> > Like that:
> > Patch 1: add the driver
> > Patch 2: add the device tree bindings
> > 
> > (instead patch 3)
> > + Patch v2 1: change 1 about feedback1 Patch v2 2: change 2 about 
> > + feedback1 ...
> > + Patch v2 10: change 3 about feedback1
> > 
> > Is it right?

> No.

> > 
> > Or should I revise it again and send it again from v2 patch 1?
> > (It's not registered with the kernel source yet..) Patch v2 1: add the 
> > driver (applied the feedback) Patch v2 2: add the device tree bindings
> > 

> Yes.  Revise again and resend everything as two patches.

> regards,
> dan carpenter


Thank you! I'll try again.
I only updates version like v2 patch as two patches(add driver & add device tree bindings) for registering a new driver.

Best regards,
Kiseok Jo