[PATCH 14/14] Fixed the retry_cnt bug about being zero

Ki-Seok Jo kiseok.jo at irondevice.com
Fri Jan 6 10:59:49 CET 2023


> On Fri, Jan 06, 2023 at 12:27:49PM +0300, Dan Carpenter wrote:
> > >  	for (index = 0; index < ARRAY_SIZE(sma1303_snd_controls); index++) {
> > >  		sma1303_controls[index] = sma1303_snd_controls[index];
> > >  		name[index] = devm_kzalloc(sma1303->dev,
> > > -				MAX_CONTROL_NAME, GFP_KERNEL);
> > > +				MAX_CONTROL_NAME*sizeof(char), GFP_KERNEL);
> > 
> > sizeof(char) is not required.  It's always zero.

> s/zero/one/ obviously.

I understand. I agree the value unnecessary. I'll remove it. Thanks
It was just put for the data type checking.

> regards,
> dan carpenter


Best regards,
Kiseok Jo


More information about the Alsa-devel mailing list