[PATCH] ASoC: codecs: Fix unsigned comparison with less than zero
Herve Codina
herve.codina at bootlin.com
Mon Feb 6 09:30:26 CET 2023
On Mon, 6 Feb 2023 15:55:18 +0800
Jiapeng Chong <jiapeng.chong at linux.alibaba.com> wrote:
> The val is defined as unsigned int type, if(val<0) is redundant, so
> delete it.
>
> sound/soc/codecs/idt821034.c:449 idt821034_kctrl_gain_put() warn: unsigned 'val' is never less than zero.
>
> Reported-by: Abaci Robot <abaci at linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3947
> Signed-off-by: Jiapeng Chong <jiapeng.chong at linux.alibaba.com>
> ---
> sound/soc/codecs/idt821034.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/codecs/idt821034.c b/sound/soc/codecs/idt821034.c
> index 5d01787b1c1f..2cc7b9166e69 100644
> --- a/sound/soc/codecs/idt821034.c
> +++ b/sound/soc/codecs/idt821034.c
> @@ -446,8 +446,6 @@ static int idt821034_kctrl_gain_put(struct snd_kcontrol *kcontrol,
> u8 ch;
>
> val = ucontrol->value.integer.value[0];
> - if (val < 0)
> - return -EINVAL;
> if (val > max - min)
> return -EINVAL;
>
Acked-by: Herve Codina <herve.codina at bootlin.com>
Thanks,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the Alsa-devel
mailing list