[PATCH 1/3] ASoC: dt-bindings: irondevice,sma1303: Rework binding and add missing properties

Mark Brown broonie at kernel.org
Fri Feb 3 14:37:13 CET 2023


On Fri, Feb 03, 2023 at 09:42:37AM +0000, Kiseok Jo wrote:

> +  sys-clk-id:
> +    description:
> +      select the using system clock.
> +      0 = External Clock 19.2MHz
> +      1 = External Clock 24.576MHz
> +      2 = Using PLL in MCLK
> +      3 = Using PLL in BCLK
> +    $ref: "/schemas/types.yaml#/definitions/uint32"
> +    maximum: 3
> +    default: 3

We really shouldn't have this as a custom property, we should be using
a combination of the clock bindings.

In the driver this would turn into using clk_get() to get the MCLK, then
we can query the rate with clk_get_rate() and use option 0 or 1 if the
rate matches, or the PLL otherwise.  If we fail to get MCLK then we can
fall back to using BCLK.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20230203/8540c37f/attachment.sig>


More information about the Alsa-devel mailing list