[PATCH 3/4] ASoC: SOF: Intel: add initial SKL/KBL hardware support

[Pierre-Louis Bossart]

On 9/20/22 14:15, Pierre-Louis Bossart wrote:
> 
> 
> On 9/20/22 13:31, Takashi Iwai wrote:
>> On Tue, 20 Sep 2022 13:19:27 +0200,
>> Mark Brown wrote:
>>>
>>> On Mon, Sep 19, 2022 at 02:36:16PM +0200, Pierre-Louis Bossart wrote:
>>>> In preparation of the IPCv4 IPC support, this patch adds
>>>> support for SkyLake and KabyLake boot and descriptors
>>>> used when probing the PCI driver.
>>>
>>> This breaks an x86_64 allmodconfig build:
>>>
>>> In file included from /build/stage/linux/sound/soc/sof/intel/hda-loader-skl.c:25:
>>> /build/stage/linux/sound/soc/sof/intel/hda-loader-skl.c: In function ‘cl_dsp_init_skl’:
>>> /build/stage/linux/sound/soc/sof/intel/hda-loader-skl.c:372:56: error: ‘HDA_DSP_ROM_STS_MASK’ undeclared (first use in this function)
>>>   372 |                                             ((status & HDA_DSP_ROM_STS_MASK)
>>>       |                                                        ^~~~~~~~~~~~~~~~~~~~
>>
>> It seems that it's defined in my tree, so maybe I need to apply those
>> on mine.  Or you can merge the for-next branch of my tree as a
>> preliminary work.  Let me know your preference.
> 
> Sorry about that, I am not sure what happened here, this constant has
> been defined since 2019. Let me double-check.
> 
> 184fdfca4ba63d (Keyon Jie             2019-07-22 09:13:51 -0500 254)
> #define HDA_DSP_ROM_STS_MASK                       GENMASK(23, 0)

My bad, this definition was removed in "ASoC: SOF: Intel: hda: Drop no
longer used ROM state definitions", and I mistakenly didn't squash the
patch from Peter that dealt with this change for SKL.

Will send a v2, sorry for the noise.