[PATCH -next 1/2] ALSA: mts64: Switch to use list_for_each_entry() helper

Yang Yingliang yangyingliang at huawei.com
Sat Sep 17 14:31:54 CEST 2022


Use list_for_each_entry() helper instead of list_for_each() and
list_entry() to simplify code a bit. No functional change.

Signed-off-by: Yang Yingliang <yangyingliang at huawei.com>
---
 sound/drivers/mts64.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/sound/drivers/mts64.c b/sound/drivers/mts64.c
index d3bc9e8c407d..746ac25a319e 100644
--- a/sound/drivers/mts64.c
+++ b/sound/drivers/mts64.c
@@ -752,7 +752,6 @@ static int snd_mts64_rawmidi_create(struct snd_card *card)
 	struct mts64 *mts = card->private_data;
 	struct snd_rawmidi *rmidi;
 	struct snd_rawmidi_substream *substream;
-	struct list_head *list;
 	int err;
 	
 	err = snd_rawmidi_new(card, CARD_NAME, 0, 
@@ -778,16 +777,16 @@ static int snd_mts64_rawmidi_create(struct snd_card *card)
 
 	/* name substreams */
 	/* output */
-	list_for_each(list, 
-		      &rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substreams) {
-		substream = list_entry(list, struct snd_rawmidi_substream, list);
+	list_for_each_entry(substream,
+			    &rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substreams,
+			    list) {
 		sprintf(substream->name,
 			"Miditerminal %d", substream->number+1);
 	}
 	/* input */
-	list_for_each(list, 
-		      &rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substreams) {
-		substream = list_entry(list, struct snd_rawmidi_substream, list);
+	list_for_each_entry(substream,
+			    &rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substreams,
+			    list) {
 		mts->midi_input_substream[substream->number] = substream;
 		switch(substream->number) {
 		case MTS64_SMPTE_SUBSTREAM:
-- 
2.25.1



More information about the Alsa-devel mailing list