[PATCH] ASoC: ak4458.c: move ak4458_reset() under CONFIG_PM

S.J. Wang shengjiu.wang at nxp.com
Tue Sep 13 04:58:23 CEST 2022


> Hi Mark
> 
> > > This patch fixup this warning
> > >
> > > linux/sound/soc/codecs/ak4458.c:631:13: error: 'ak4458_reset' defined
> but\
> > >     not used [-Werror=unused-function]
> > >   631 | static void ak4458_reset(struct ak4458_priv *ak4458, bool active)
> > >       |             ^~~~~~~~~~~~
> > > cc1: all warnings being treated as errors
> > >
> > > Fixes: e9e7df88996d64 ("ASoC: ak4458: Remove component probe() and
> > > remove()")
> >
> > Is this the best fix, or should we be adding _reset() calls into the
> > device level probe() and remove() functions?
> 
> Hmm... I'm not familiar with ak4458.c.
> Is your opinion for original patch ? or this patch ?
> This patch is just trying to fix the compile issue.
> 
> Thank you for your help !!
> 

Thanks for catching this issue.
Without or with _reset() in probe() and remove(), the driver can work in both
case.

Best regards
Wang shengjiu



More information about the Alsa-devel mailing list