[PATCH 2/2] ASoC: dt-bindings: nau8825: Add ADCOUT IO drive strength control

Mark Brown broonie at kernel.org
Mon Sep 12 14:05:47 CEST 2022


On Mon, Sep 12, 2022 at 07:54:29PM +0800, David Lin wrote:

> +  - nuvoton,adcout-drive-str: make ADCOUT IO drive strength with stronger if set.
> +

This isn't the clearest property name or description TBH.  For a
device specific setting like this it might be clearer to add a
reference to the register bit so it's easier for people to tie
the behaviour back to the actual device behaviour change.
There's also probably something clearer than "stronger" that
could be used here.

Perhaps adding something like "strong" would be good - with the
name I'd expected the property to be a numerical strength rather
than a boolean.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220912/ed010f51/attachment.sig>


More information about the Alsa-devel mailing list