[PATCH] dt-bindings: sound: ts3a227e: add control of debounce times
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Fri Sep 9 09:25:16 CEST 2022
On 09/09/2022 09:16, Astrid Rost wrote:
> Hello,
>
> > Use standard property units "-ms".
>
> I made it in exactly the same way as it is done for the "ti,micbias:".
>
> - ti,micbias: Intended MICBIAS voltage (datasheet section 9.6.7).
> Select 0/1/2/3/4/5/6/7 to specify MICBIAS voltage
> 2.1V/2.2V/2.3V/2.4V/2.5V/2.6V/2.7V/2.8V
> Default value is "1" (2.2V).
That's not correct way. Logical units should be encoded in logical
units, e.g. microvolt. This makes the binding re-usable, extendable
(imagine new device from the family where these values map to something
else!) and also the easiest to read.
> ?> Anyway new properties cannot be accepted. This has to be converted to DT
> ?> schema (YAML).
>
> > Doing a whole binding conversion feels like a bit of a steep requirement
> > when people are just adding a simple property, it's a lot of stop energy
> > to figure out the tooling, do the conversion and deal with all the
> > bikeshedding that the tools don't catch. It's definitely nice if people
> > want to look at that, for more complex binding changes it gets more
> > reasonable but for trivial properties it's disproportionate.
>
> Thanks, I am not really sure how yaml works. But I can have a look.
Documentation/devicetree/bindings/writing-schema.rst
(and example-schema in the same place)
Best regards,
Krzysztof
More information about the Alsa-devel
mailing list