[PATCH] ASoC: nau8825: Add ADCOUT IO drive strength control

[Mark Brown]

On Wed, Sep 07, 2022 at 02:51:27PM +0800, David Lin wrote:
> Add a property to control the driving of ADCOUT.
> 
> Signed-off-by: David Lin <CTLIN0 at nuvoton.com>
> ---
>  Documentation/devicetree/bindings/sound/nau8825.txt | 2 ++
>  sound/soc/codecs/nau8825.c                          | 6 ++++++
>  sound/soc/codecs/nau8825.h                          | 3 +++
>  3 files changed, 11 insertions(+)

Binding and driver patches should normally be separate patches.

> +  - nuvoton,adcout-drive-str: ADCOUT IO drive strength. 0 - normal, 1 - stronger.

Why not just make this a boolean property rather than requiring values?

> +	nau8825->adcout_ds = device_property_read_bool(dev, "nuvoton,adcout-drive-str");

It looks like it's being parsed as a boolean.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220907/ab41ccf7/attachment.sig>