[PATCH 3/3] ASoC: adau1372: correct PGA enable & mute bit

Sa, Nuno Nuno.Sa at analog.com
Mon Oct 31 12:22:44 CET 2022



> -----Original Message-----
> From: Maarten Zanders <maarten.zanders at mind.be>
> Sent: Friday, October 28, 2022 5:26 PM
> To: Lars-Peter Clausen <lars at metafoo.de>; Sa, Nuno
> <Nuno.Sa at analog.com>; Liam Girdwood <lgirdwood at gmail.com>; Mark
> Brown <broonie at kernel.org>; Jaroslav Kysela <perex at perex.cz>; Takashi
> Iwai <tiwai at suse.com>
> Cc: Maarten Zanders <maarten.zanders at mind.be>; alsa-devel at alsa-
> project.org; linux-kernel at vger.kernel.org
> Subject: [PATCH 3/3] ASoC: adau1372: correct PGA enable & mute bit
> 
> [External]
> 
> The DAPM control for PGAx uses the PGA mute bit for
> power management. This bit is active high but is set to
> non-inverted (ie when powering, it will mute).
> The ALSA control "PGA x Capture Switch" uses the active
> high PGA_ENx bit, but is set to inverted. So when
> enabling this switch, the PGA gets disabled.
> 
> To correct the behaviour, invert both these bits.
> 
> Signed-off-by: Maarten Zanders <maarten.zanders at mind.be>
> ---

Also looks like a fix so a Fixes: tag? If so, the patch should come
before ("ASoC: adau1372: add support for S24_LE mode")

- Nuno Sá


More information about the Alsa-devel mailing list