[PATCH] soundwire: intel: Initialize clock stop timeout

Vinod Koul vkoul at kernel.org
Fri Oct 28 13:28:39 CEST 2022


On 20-10-22, 09:56, Bard Liao wrote:
> From: Sjoerd Simons <sjoerd at collabora.com>
> 
> The bus->clk_stop_timeout member is only initialized to a non-zero value
> during the codec driver probe. This can lead to corner cases where this
> value remains pegged at zero when the bus suspends, which results in an
> endless loop in sdw_bus_wait_for_clk_prep_deprep().
> 
> Corner cases include configurations with no codecs described in the
> firmware, or delays in probing codec drivers.
> 
> Initializing the default timeout to the smallest non-zero value avoid this
> problem and allows for the existing logic to be preserved: the
> bus->clk_stop_timeout is set as the maximum required by all codecs
> connected on the bus.

Applied to fixes, thanks

-- 
~Vinod


More information about the Alsa-devel mailing list