[PATCH] ALSA/ASoC: replace ternary operator with min()

Mark Brown broonie at kernel.org
Tue Oct 25 19:01:32 CEST 2022


On Tue, Oct 25, 2022 at 10:56:11PM +0800, wangkailong at jari.cn wrote:
> Fix the following coccicheck warning:
> 
> sound/soc/soc-ops.c:817: WARNING opportunity for min()

>  	kfree(uctl);
> -	return err < 0 ? err : 0;
> +	return min(err, 0);

I don't think this is a good warning, while I'm no big fan of the
ternery operator the new code is less clear about the intent than the
old code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 484 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20221025/acc13163/attachment.sig>


More information about the Alsa-devel mailing list