[PATCH 12/19] ASoC: SOF: Intel: Set the default firmware library path for IPC4

[Cezary Rojewski]

On 2022-10-18 3:49 PM, Péter Ujfalusi wrote:
> On 18/10/2022 15:38, Amadeusz Sławiński wrote:

...

>> I'm not sure that I understand the rationale here, can't libraries be
>> kept in the same directory as FW, as far as I know they are version
>> locked to FW anyway.
> 
> During the internal review we arrived to this setup, to keep the
> libraries separate from the basefw binary.
> One of the reason is that SOF project is not likely not going to release
> external libraries, they are mostly vendor/product locked.
> To make the life easier for the vendors (and distributions, packagers)
> we concluded that it is better to keep them separate.
> 
> The option is there to specify custom path as well in case it is needed.

Thanks for detailed answer, Peter. My two cents:

I'd say the origin of the library has a saying in that. If it's 
implemented by a vendor then it's simply not our decision. If it's made 
by us (Intel), it's highly probable that there's no problem with sharing 
the library. Library alone is often not enough - to process data as 
expected on the specific hardware, additional configuration is needed. 
We share that information over SRAM between the driver and the firmware. 
And that's the key bit that should not be shared here.

As the basefw makes use of different prefixes when compared to the 
libraries, I believe it's fine to leave as is. If an error is made when 
differentiating between dsp_fw_* and dsp_lib_* then introducing avs-lib/ 
is not going to help here. It's also much less hassle with matching the 
basefw and lib versions if you have them both within single folder, 
granted both target same AudioDSP generation (SKL-based, APL-based etc.).

>> In avs driver when we decided on intel/avs/platform
>> path we planned to keep FW related libaries there...
> 
> My initial approach was this as well, but after a long debate it got
> revised.

Amadeo: have my bow..
Czarek: ..and my axe..


Regards,
Czarek