[PATCH v2 02/11] ASoC: dt-bindings: qcom,apr: Split services to shared schema
Rob Herring
robh at kernel.org
Wed Nov 16 15:33:02 CET 2022
On Tue, 15 Nov 2022 13:02:26 +0100, Krzysztof Kozlowski wrote:
> The APR/GPR nodes are organized like:
>
> apr-or-gpr-device-node <- qcom,apr.yaml
> apr-gpr-service@[0-9] <- qcom,apr.yaml
> service-specific-components <- /schemas/sound/qcom,q6*.yaml
>
> The schema for services (apr-gpr-service@[0-9]) already grows
> considerably and is still quite not specific. It allows several
> incorrect combinations, like adding a clock-controller to a APM device.
> Restricting it would complicate the schema even more. Bringing new
> support for sound on Qualcomm SM8450 and SC8280XP SoC would grow it as
> well.
>
> Simplify the qcom,apr.yaml by splitting the services to a shared file
> which will be:
> 1. Referenced by qcom,apr.yaml with additionalProperties:true,
> 2. Referenced by specific bindings for services with
> additionalProperties:false (not yet in this commit).
>
> While moving the code, add also required 'reg' and
> 'qcom,protection-domain' to further constrain the bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>
> ---
>
> Changes since v1:
> 1. Keep compatibles in qcom,apr.yaml
>
> Cc: quic_srivasam at quicinc.com
> Cc: quic_plai at quicinc.com
> ---
> .../bindings/soc/qcom/qcom,apr-services.yaml | 54 ++++++++++
> .../bindings/soc/qcom/qcom,apr.yaml | 98 +------------------
> MAINTAINERS | 2 +-
> 3 files changed, 58 insertions(+), 96 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml
>
Reviewed-by: Rob Herring <robh at kernel.org>
More information about the Alsa-devel
mailing list