Discuss [PATCH V4 6/6] ASoC:codecs:aw883xx corresponds to the modified Makefile and Kconfig

wangweidong.a at awinic.com wangweidong.a at awinic.com
Tue Nov 15 12:47:55 CET 2022


Hi Krzysztof Kozlowski

Thank you very much for your advice, but there is still a problem I would like to discuss with you

> From: Weidong Wang <wangweidong.a at awinic.com>
> 
> Modified the Makefile and Kconfig to compile aw883xx
> 
> Signed-off-by: Weidong Wang <wangweidong.a at awinic.com>
> ---
>  sound/soc/codecs/Kconfig  | 10 ++++++++++  sound/soc/codecs/Makefile 
> |  7 +++++++
>  2 files changed, 17 insertions(+)

> 1. Where is patch 5?

What does this mean? Did you not receive patch V4 5/6?

> 2. Subject: missing spaces.

I would add this space at patch v5

> 3. This should be squashed with previous. There is no point to have commits adding dead code, therefore this one as a separate commit does not make sense.

I will change this issue on patch v5

Best regards,
Weidong Wang



More information about the Alsa-devel mailing list