[PATCH v1] sound/pci/hda/patch_realtek: don't call alc_shutup_pins without a spec

Daniil Tatianin d-tatianin at yandex-team.ru
Mon Nov 14 09:20:48 CET 2022


alc_shutup_pins always expects the spec to be present, so make sure
it is before we call it.

Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.

Signed-off-by: Daniil Tatianin <d-tatianin at yandex-team.ru>
---
 sound/pci/hda/patch_realtek.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 60e3bc124836..2cf4b64971d7 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -939,10 +939,12 @@ static inline void alc_shutup(struct hda_codec *codec)
 {
 	struct alc_spec *spec = codec->spec;
 
+	if (!spec)
+		return;
 	if (!snd_hda_get_bool_hint(codec, "shutup"))
 		return; /* disabled explicitly by hints */
 
-	if (spec && spec->shutup)
+	if (spec->shutup)
 		spec->shutup(codec);
 	else
 		alc_shutup_pins(codec);
-- 
2.25.1



More information about the Alsa-devel mailing list