[PATCH 5/6] arm64: dts: fsd: Add I2S DAI node for Tesla FSD

[Padmanabhan Rajanbabu]

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski at linaro.org]
> Sent: 21 October 2022 06:32 PM
> To: Padmanabhan Rajanbabu <p.rajanbabu at samsung.com>;
> lgirdwood at gmail.com; broonie at kernel.org; robh+dt at kernel.org;
> krzysztof.kozlowski+dt at linaro.org; s.nawrocki at samsung.com;
> perex at perex.cz; tiwai at suse.com; pankaj.dubey at samsung.com;
> alim.akhtar at samsung.com; rcsekar at samsung.com;
> aswani.reddy at samsung.com
> Cc: alsa-devel at alsa-project.org; devicetree at vger.kernel.org; linux-
> kernel at vger.kernel.org; linux-samsung-soc at vger.kernel.org
> Subject: Re: [PATCH 5/6] arm64: dts: fsd: Add I2S DAI node for Tesla FSD
> 
> On 21/10/2022 04:49, Padmanabhan Rajanbabu wrote:
> >>>
> >>>  	cpus {
> >>> @@ -809,6 +811,42 @@
> >>>  			status = "disabled";
> >>>  		};
> >>>
> >>> +		tdm_0: tdm at 140e0000 {
> >>
> >> Node names should be generic, so this looks like i2s.
> >> https://protect2.fireeye.com/v1/url?k=2cfaa5af-4d874de8-2cfb2ee0-
> >> 74fe485fff30-cb16acc0c0c574e9&q=1&e=fc8e3b54-a0ef-475e-a4f2-
> >> 83626a86ac8a&u=https%3A%2F%2Fdevicetree-
> >> specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree-
> >> basics.html%23generic-names-recommendation
> >
> > Thank you for the link. I could only find audio-controller in the list
> > and not i2s. so I believe I can use audio-controller node name. Please
> > correct me otherwise.
> 
> All I2S controllers use node name "i2s", so if this is I2S, then use "i2s".

Okay, I'll ensure the next version will use "i2s" node name

> 
> 
> Best regards,
> Krzysztof