[PATCH v2 00/65] clk: Make determine_rate mandatory for muxes
Maxime Ripard
maxime at cerno.tech
Fri Nov 4 14:17:17 CET 2022
Hi,
This is a follow-up to a previous series that was printing a warning
when a mux has a set_parent implementation but is missing
determine_rate().
The rationale is that set_parent() is very likely to be useful when
changing the rate, but it's determine_rate() that takes the parenting
decision. If we're missing it, then the current parent is always going
to be used, and thus set_parent() will not be used. The only exception
being a direct call to clk_set_parent(), but those are fairly rare
compared to clk_set_rate().
Stephen then asked to promote the warning to an error, and to fix up all
the muxes that are in that situation first. So here it is :)
Let me know what you think,
Maxime
To: Michael Turquette <mturquette at baylibre.com>
To: Stephen Boyd <sboyd at kernel.org>
To: Andreas Färber <afaerber at suse.de>
To: Manivannan Sadhasivam <mani at kernel.org>
To: Nicolas Ferre <nicolas.ferre at microchip.com>
To: Alexandre Belloni <alexandre.belloni at bootlin.com>
To: Claudiu Beznea <claudiu.beznea at microchip.com>
To: Max Filippov <jcmvbkbc at gmail.com>
To: Charles Keepax <ckeepax at opensource.cirrus.com>
To: Richard Fitzgerald <rf at opensource.cirrus.com>
To: Maxime Coquelin <mcoquelin.stm32 at gmail.com>
To: Alexandre Torgue <alexandre.torgue at foss.st.com>
To: Luca Ceresoli <luca.ceresoli at bootlin.com>
To: David Lechner <david at lechnology.com>
To: Sekhar Nori <nsekhar at ti.com>
To: Abel Vesa <abelvesa at kernel.org>
To: Shawn Guo <shawnguo at kernel.org>
To: Sascha Hauer <s.hauer at pengutronix.de>
To: Pengutronix Kernel Team <kernel at pengutronix.de>
To: Fabio Estevam <festevam at gmail.com>
To: NXP Linux Team <linux-imx at nxp.com>
To: Matthias Brugger <matthias.bgg at gmail.com>
To: Geert Uytterhoeven <geert+renesas at glider.be>
To: Dinh Nguyen <dinguyen at kernel.org>
To: Peter De Schrijver <pdeschrijver at nvidia.com>
To: Prashant Gaikwad <pgaikwad at nvidia.com>
To: Thierry Reding <thierry.reding at gmail.com>
To: Jonathan Hunter <jonathanh at nvidia.com>
To: Ulf Hansson <ulf.hansson at linaro.org>
To: Linus Walleij <linus.walleij at linaro.org>
To: David Airlie <airlied at gmail.com>
To: Daniel Vetter <daniel at ffwll.ch>
To: Vinod Koul <vkoul at kernel.org>
To: Kishon Vijay Abraham I <kishon at kernel.org>
To: Alessandro Zummo <a.zummo at towertech.it>
To: Chen-Yu Tsai <wens at csie.org>
To: Jernej Skrabec <jernej.skrabec at gmail.com>
To: Samuel Holland <samuel at sholland.org>
To: Liam Girdwood <lgirdwood at gmail.com>
To: Mark Brown <broonie at kernel.org>
To: Jaroslav Kysela <perex at perex.cz>
To: Takashi Iwai <tiwai at suse.com>
To: Paul Cercueil <paul at crapouillou.net>
To: Orson Zhai <orsonzhai at gmail.com>
To: Baolin Wang <baolin.wang at linux.alibaba.com>
To: Chunyan Zhang <zhang.lyra at gmail.com>
Cc: linux-clk at vger.kernel.org
Cc: linux-kernel at vger.kernel.org
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-actions at lists.infradead.org
Cc: patches at opensource.cirrus.com
Cc: linux-stm32 at st-md-mailman.stormreply.com
Cc: linux-mediatek at lists.infradead.org
Cc: linux-renesas-soc at vger.kernel.org
Cc: linux-tegra at vger.kernel.org
Cc: dri-devel at lists.freedesktop.org
Cc: linux-phy at lists.infradead.org
Cc: linux-rtc at vger.kernel.org
Cc: linux-sunxi at lists.linux.dev
Cc: alsa-devel at alsa-project.org
Cc: linux-mips at vger.kernel.org
Signed-off-by: Maxime Ripard <maxime at cerno.tech>
---
Changes in v2:
- Drop all the patches already applied
- Promote the clk registration warning to an error
- Make all muxes use determine_rate
- Link to v1: https://lore.kernel.org/r/20221018-clk-range-checks-fixes-v1-0-f3ef80518140@cerno.tech
---
Maxime Ripard (65):
clk: Export clk_hw_forward_rate_request()
clk: lan966x: Remove unused round_rate hook
clk: nodrv: Add a determine_rate hook
clk: test: Add a determine_rate hook
clk: actions: composite: Add a determine_rate hook for pass clk
clk: at91: main: Add a determine_rate hook
clk: at91: sckc: Add a determine_rate hook
clk: berlin: div: Add a determine_rate hook
clk: cdce706: Add a determine_rate hook
clk: k210: pll: Add a determine_rate hook
clk: k210: aclk: Add a determine_rate hook
clk: k210: mux: Add a determine_rate hook
clk: lmk04832: clkout: Add a determine_rate hook
clk: lochnagar: Add a determine_rate hook
clk: qoriq: Add a determine_rate hook
clk: si5341: Add a determine_rate hook
clk: stm32f4: mux: Add a determine_rate hook
clk: vc5: mux: Add a determine_rate hook
clk: vc5: clkout: Add a determine_rate hook
clk: wm831x: clkout: Add a determine_rate hook
clk: davinci: da8xx-cfgchip: Add a determine_rate hook
clk: davinci: da8xx-cfgchip: Add a determine_rate hook
clk: imx: busy: Add a determine_rate hook
clk: imx: fixup-mux: Add a determine_rate hook
clk: imx: scu: Add a determine_rate hook
clk: mediatek: cpumux: Add a determine_rate hook
clk: pxa: Add a determine_rate hook
clk: renesas: r9a06g032: Add a determine_rate hook
clk: socfpga: gate: Add a determine_rate hook
clk: stm32: core: Add a determine_rate hook
clk: tegra: bpmp: Add a determine_rate hook
clk: tegra: super: Add a determine_rate hook
clk: tegra: periph: Add a determine_rate hook
clk: ux500: prcmu: Add a determine_rate hook
clk: ux500: sysctrl: Add a determine_rate hook
clk: versatile: sp810: Add a determine_rate hook
drm/tegra: sor: Add a determine_rate hook
phy: cadence: sierra: Add a determine_rate hook
phy: cadence: torrent: Add a determine_rate hook
phy: ti: am654-serdes: Add a determine_rate hook
phy: ti: j721e-wiz: Add a determine_rate hook
rtc: sun6i: Add a determine_rate hook
ASoC: tlv320aic32x4: Add a determine_rate hook
clk: actions: composite: div: Switch to determine_rate
clk: actions: composite: fact: Switch to determine_rate
clk: at91: smd: Switch to determine_rate
clk: axi-clkgen: Switch to determine_rate
clk: cdce706: divider: Switch to determine_rate
clk: cdce706: clkout: Switch to determine_rate
clk: si5341: Switch to determine_rate
clk: si5351: pll: Switch to determine_rate
clk: si5351: msynth: Switch to determine_rate
clk: si5351: clkout: Switch to determine_rate
clk: da8xx: clk48: Switch to determine_rate
clk: imx: scu: Switch to determine_rate
clk: ingenic: cgu: Switch to determine_rate
clk: ingenic: tcu: Switch to determine_rate
clk: sprd: composite: Switch to determine_rate
clk: st: flexgen: Switch to determine_rate
clk: stm32: composite: Switch to determine_rate
clk: tegra: periph: Switch to determine_rate
clk: tegra: super: Switch to determine_rate
ASoC: tlv320aic32x4: pll: Switch to determine_rate
ASoC: tlv320aic32x4: div: Switch to determine_rate
clk: Warn if we register a mux without determine_rate
drivers/clk/actions/owl-composite.c | 35 +++++++++++-----
drivers/clk/actions/owl-composite.h | 2 +-
drivers/clk/at91/clk-main.c | 3 +-
drivers/clk/at91/clk-smd.c | 29 +++++++------
drivers/clk/at91/sckc.c | 3 +-
drivers/clk/berlin/berlin2-div.c | 3 +-
drivers/clk/clk-axi-clkgen.c | 14 ++++---
drivers/clk/clk-cdce706.c | 31 ++++++++------
drivers/clk/clk-k210.c | 17 +++++---
drivers/clk/clk-lan966x.c | 17 --------
drivers/clk/clk-lmk04832.c | 1 +
drivers/clk/clk-lochnagar.c | 2 +
drivers/clk/clk-qoriq.c | 10 +++--
drivers/clk/clk-si5341.c | 21 +++++-----
drivers/clk/clk-si5351.c | 67 +++++++++++++++++--------------
drivers/clk/clk-stm32f4.c | 3 +-
drivers/clk/clk-versaclock5.c | 8 ++--
drivers/clk/clk-wm831x.c | 3 +-
drivers/clk/clk.c | 15 +++++++
drivers/clk/clk_test.c | 1 +
drivers/clk/davinci/da8xx-cfgchip.c | 15 ++++---
drivers/clk/imx/clk-busy.c | 3 +-
drivers/clk/imx/clk-fixup-mux.c | 3 +-
drivers/clk/imx/clk-scu.c | 27 +++++++++++--
drivers/clk/ingenic/cgu.c | 15 +++----
drivers/clk/ingenic/tcu.c | 19 +++++----
drivers/clk/mediatek/clk-cpumux.c | 3 +-
drivers/clk/pxa/clk-pxa.c | 3 +-
drivers/clk/renesas/r9a06g032-clocks.c | 3 +-
drivers/clk/socfpga/clk-gate.c | 3 +-
drivers/clk/sprd/composite.c | 16 +++++---
drivers/clk/st/clk-flexgen.c | 15 +++----
drivers/clk/stm32/clk-stm32-core.c | 32 ++++++++++-----
drivers/clk/tegra/clk-bpmp.c | 7 +++-
drivers/clk/tegra/clk-periph.c | 19 ++++++---
drivers/clk/tegra/clk-super.c | 18 ++++++---
drivers/clk/ux500/clk-prcmu.c | 3 +-
drivers/clk/ux500/clk-sysctrl.c | 4 +-
drivers/clk/versatile/clk-sp810.c | 3 +-
drivers/gpu/drm/tegra/sor.c | 3 +-
drivers/phy/cadence/phy-cadence-sierra.c | 1 +
drivers/phy/cadence/phy-cadence-torrent.c | 1 +
drivers/phy/ti/phy-am654-serdes.c | 1 +
drivers/phy/ti/phy-j721e-wiz.c | 1 +
drivers/rtc/rtc-sun6i.c | 2 +
sound/soc/codecs/tlv320aic32x4-clk.c | 37 ++++++++++-------
46 files changed, 343 insertions(+), 199 deletions(-)
---
base-commit: 61c3426aca2c71052ddcd06c32e29d92304990fd
change-id: 20221018-clk-range-checks-fixes-2039f3523240
Best regards,
--
Maxime Ripard <maxime at cerno.tech>
More information about the Alsa-devel
mailing list