[PATCH] ALSA: usb-audio: Fix regression with Dell Dock jack detection
Jaroslav Kysela
perex at perex.cz
Wed Nov 2 15:05:40 CET 2022
On 02. 11. 22 13:45, Takashi Iwai wrote:
> BTW, while looking at this bug, I noticed another bug in alsa-lib
> src/ucm/main.c. The check in snd_use_case_parse_ctl_elem_id() should
> be rather to the value, not the identifier:
>
> --- a/src/ucm/main.c
> +++ b/src/ucm/main.c
> @@ -2793,7 +2793,7 @@ int snd_use_case_parse_ctl_elem_id(snd_ctl_elem_id_t *dst,
> strcmp(ucm_id, "CaptureSwitch"))
> return -EINVAL;
> snd_ctl_elem_id_clear(dst);
> - if (strcasestr(ucm_id, "name="))
> + if (strcasestr(value, "name="))
> return __snd_ctl_ascii_elem_id_parse(dst, value, NULL);
> iface = SND_CTL_ELEM_IFACE_MIXER;
> if (jack_control)
Oops. Thanks, it looks like an obvious thinko. Fixed right now.
Jaroslav
--
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
More information about the Alsa-devel
mailing list