[PATCH v5 2/4] update tas27xx.h to support either TAS2764 or TAS2780

Mark Brown broonie at kernel.org
Thu Mar 31 14:12:51 CEST 2022


On Wed, Mar 30, 2022 at 10:45:24PM +0800, Raphael-Xu wrote:

>  /* Book Control Register */
> -#define TAS2764_BOOKCTL_PAGE	0
> -#define TAS2764_BOOKCTL_REG	127
> -#define TAS2764_REG(page, reg)	((page * 128) + reg)
> +#define TAS27XX_BOOKCTL_PAGE	0
> +#define TAS27XX_BOOKCTL_REG	127
> +#define TAS27XX_REG(page, reg)	((page * 128) + reg)

You should ensure that each patch is individually buildable - this helps
people who want to do things like bisecting for problems.  This means
that you shouldn't go file by file but instead logical change by logical
change.  I think all you need to do here is just make patches 2 and 3
into a single patch.

Otherwise this looks basically good, please update for the above and
also the small issues that Amadeusz pointed out.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220331/06e2fb4e/attachment.sig>


More information about the Alsa-devel mailing list