[PATCH] ASoC: SOF: topology: use new sound control LED layer

Jaroslav Kysela perex at perex.cz
Tue Mar 29 13:59:44 CEST 2022


On 29. 03. 22 12:16, Péter Ujfalusi wrote:
> Hi Jaroslav,
> 
> On 29/03/2022 11:03, Jaroslav Kysela wrote:
>> Use the new sound control LED layer instead the direct ledtrig_audio_set()
>> call - see 22d8de62f11b ("ALSA: control - add generic LED trigger module
>> as the new control layer").
> 
> Don't we need to select SND_CTL_LED from SOF to make sure that the LED
> trigger module is available?

This feature is optional and the current code does not even forcefully select 
the LEDS_TRIGGERS and LEDS_TRIGGER_AUDIO, too. There was 
IS_REACHABLE(CONFIG_LEDS_TRIGGER_AUDIO) condition. I think that this change 
should be handled separately (if required).

Unfortunately, I forgot to call snd_ctl_led_request() to load the LED trigger
module when available. I will send v2 ASAP.

				Jaroslav

-- 
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.


More information about the Alsa-devel mailing list